Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DialogRequester -> DialogType Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views.h ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h" 5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/i18n/rtl.h" 9 #include "base/i18n/rtl.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 457
458 void AutofillDialogViews::HideSignIn() { 458 void AutofillDialogViews::HideSignIn() {
459 sign_in_container_->SetVisible(false); 459 sign_in_container_->SetVisible(false);
460 main_container_->SetVisible(true); 460 main_container_->SetVisible(true);
461 } 461 }
462 462
463 void AutofillDialogViews::UpdateProgressBar(double value) { 463 void AutofillDialogViews::UpdateProgressBar(double value) {
464 autocheckout_progress_bar_->SetValue(value); 464 autocheckout_progress_bar_->SetValue(value);
465 } 465 }
466 466
467 void AutofillDialogViews::SubmitForTesting() {
Evan Stade 2013/02/06 00:29:32 seems like this should be: if (Accept()) Hide()
Ilya Sherman 2013/02/06 00:41:34 Accept() fails because the inputs fail to validate
Ilya Sherman 2013/02/06 01:45:28 Done. Good call on override the AutofillDialogCon
468 did_submit_ = true;
469 Hide();
470 }
471
472 void AutofillDialogViews::CancelForTesting() {
473 did_submit_ = false;
474 Hide();
475 }
476
467 string16 AutofillDialogViews::GetWindowTitle() const { 477 string16 AutofillDialogViews::GetWindowTitle() const {
468 return controller_->DialogTitle(); 478 return controller_->DialogTitle();
469 } 479 }
470 480
471 void AutofillDialogViews::WindowClosing() { 481 void AutofillDialogViews::WindowClosing() {
472 focus_manager_->RemoveFocusChangeListener(this); 482 focus_manager_->RemoveFocusChangeListener(this);
473 } 483 }
474 484
475 void AutofillDialogViews::DeleteDelegate() { 485 void AutofillDialogViews::DeleteDelegate() {
476 window_ = NULL; 486 window_ = NULL;
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section) 950 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
941 : section(section), 951 : section(section),
942 container(NULL), 952 container(NULL),
943 manual_input(NULL), 953 manual_input(NULL),
944 suggested_info(NULL), 954 suggested_info(NULL),
945 suggested_button(NULL) {} 955 suggested_button(NULL) {}
946 956
947 AutofillDialogViews::DetailsGroup::~DetailsGroup() {} 957 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
948 958
949 } // namespace autofill 959 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views.h ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698