[Autofill] Add UMA timing metrics for requestAutocomplete dialog.

chrome/browser/autofill/autofill_metrics.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_metrics.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/time.h"
 #include "chrome/browser/autofill/autofill_type.h"
@@ skipping 142 matching lines @@
   // Interpolate the |metric| with the |group|, so that all metrics for a given
   // |group| are adjacent.
   return (group * num_possible_metrics) + metric;
 }
 
 // A version of the UMA_HISTOGRAM_ENUMERATION macro that allows the |name|
 // to vary over the program's runtime.
 void LogUMAHistogramEnumeration(const std::string& name,
                                 int sample,
                                 int boundary_value) {
-  // We can't use the UMA_HISTOGRAM_ENUMERATION macro here because the histogram
-  // name can vary over the duration of the program.
-  // Note that this leaks memory; that is expected behavior.
-  base::HistogramBase* counter =
+  // Note: This leaks memory, which is expected behavior.
+  base::HistogramBase* histogram =
       base::LinearHistogram::FactoryGet(
           name,
           1,
           boundary_value,
           boundary_value + 1,
           base::HistogramBase::kUmaTargetedHistogramFlag);
-  counter->Add(sample);
+  histogram->Add(sample);
+}
+
+// A version of the UMA_HISTOGRAM_LONG_TIMES macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramLongTimes(const std::string& name,
+                              const base::TimeDelta& duration) {
+  // Note: This leaks memory, which is expected behavior.
+  base::HistogramBase* histogram =
+      base::Histogram::FactoryTimeGet(
+          name,
+          base::TimeDelta::FromMilliseconds(1),
+          base::TimeDelta::FromHours(1),
+          50,
+          base::HistogramBase::kUmaTargetedHistogramFlag);
+  histogram->AddTime(duration);
 }
 
 // Logs a type quality metric.  The primary histogram name is constructed based
 // on |base_name| and |experiment_id|.  The field-specific histogram name also
 // factors in the |field_type|.  Logs a sample of |metric|, which should be in
 // the range [0, |num_possible_metrics|).
 void LogTypeQualityMetric(const std::string& base_name,
                           const int metric,
                           const int num_possible_metrics,
                           const AutofillFieldType field_type,
@@ skipping 77 matching lines @@
                             NUM_INFO_BAR_METRICS);
 }
 
 void AutofillMetrics::LogAutocheckoutInfoBarMetric(InfoBarMetric metric) const {
   DCHECK(metric < NUM_INFO_BAR_METRICS);
 
   UMA_HISTOGRAM_ENUMERATION("Autofill.AutocheckoutInfoBar", metric,
                             NUM_INFO_BAR_METRICS);
 }
 
+void AutofillMetrics::LogRequestAutocompleteUiDuration(
+    const base::TimeDelta& duration,
+    autofill::DialogRequester requester,
+    DialogDismissalAction dismissal_action) const {
+  std::string prefix;
+  switch (requester) {
+    case autofill::DIALOG_REQUESTER_AUTOCHECKOUT:
+      prefix = "Autocheckout";
+      break;
+
+    case autofill::DIALOG_REQUESTER_REQUEST_AUTOCOMPLETE:
+      prefix = "RequestAutocomplete";
+      break;
+  }
+
+  std::string suffix;
+  switch (dismissal_action) {
+    case DIALOG_ACCEPTED:
+      suffix = "Submit";
+      break;
+
+    case DIALOG_CANCELED:
+      suffix = "Cancel";
+      break;
+  }
+
+  LogUMAHistogramLongTimes(prefix + ".UiDuration", duration);
+  LogUMAHistogramLongTimes(prefix + ".UiDuration." + suffix, duration);
+}
+

[Evan Stade, 2013/02/05 20:06:41]

^H

[Ilya Sherman, 2013/02/06 00:02:25]

Done.

+
 void AutofillMetrics::LogDeveloperEngagementMetric(
     DeveloperEngagementMetric metric) const {
   DCHECK(metric < NUM_DEVELOPER_ENGAGEMENT_METRICS);
 
   UMA_HISTOGRAM_ENUMERATION("Autofill.DeveloperEngagement", metric,
                             NUM_DEVELOPER_ENGAGEMENT_METRICS);
 }
 
 void AutofillMetrics::LogHeuristicTypePrediction(
     FieldTypeQualityMetric metric,
@@ skipping 103 matching lines @@
 
 void AutofillMetrics::LogServerExperimentIdForQuery(
     const std::string& experiment_id) const {
   LogServerExperimentId("Autofill.ServerExperimentId.Query", experiment_id);
 }
 
 void AutofillMetrics::LogServerExperimentIdForUpload(
     const std::string& experiment_id) const {
   LogServerExperimentId("Autofill.ServerExperimentId.Upload", experiment_id);
 }