Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/browser/autofill/autofill_manager_delegate.h

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the test. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_DELEGATE_H_
6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_DELEGATE_H_ 6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_DELEGATE_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 9
10 namespace autofill { 10 namespace autofill {
11 class PasswordGenerator; 11 class PasswordGenerator;
12 } 12 }
13 13
14 namespace content { 14 namespace content {
15 class BrowserContext; 15 class BrowserContext;
16 struct PasswordForm; 16 struct PasswordForm;
17 struct SSLStatus; 17 struct SSLStatus;
18 } 18 }
19 19
20 namespace gfx { 20 namespace gfx {
21 class Rect; 21 class Rect;
22 } 22 }
23 23
24 class AutofillMetrics;
24 class FormStructure; 25 class FormStructure;
25 class GURL; 26 class GURL;
26 class InfoBarService; 27 class InfoBarService;
27 class PrefServiceBase; 28 class PrefServiceBase;
28 class Profile; 29 class Profile;
29 class ProfileSyncServiceBase; 30 class ProfileSyncServiceBase;
30 31
31 struct FormData; 32 struct FormData;
32 33
33 namespace autofill { 34 namespace autofill {
34 35
36 enum DialogRequester {
Evan Stade 2013/02/05 20:06:41 Not a fan of this name. DialogType?
Ilya Sherman 2013/02/06 00:02:25 Done.
37 // Requested by the Autocheckout feature.
38 DIALOG_REQUESTER_AUTOCHECKOUT,
39 // Requested by the requestAutocomplete feature.
40 DIALOG_REQUESTER_REQUEST_AUTOCOMPLETE,
41 };
42
35 // A delegate interface that needs to be supplied to AutofillManager 43 // A delegate interface that needs to be supplied to AutofillManager
36 // by the embedder. 44 // by the embedder.
37 // 45 //
38 // Each delegate instance is associated with a given context within 46 // Each delegate instance is associated with a given context within
39 // which an AutofillManager is used (e.g. a single tab), so when we 47 // which an AutofillManager is used (e.g. a single tab), so when we
40 // say "for the delegate" below, we mean "in the execution context the 48 // say "for the delegate" below, we mean "in the execution context the
41 // delegate is associated with" (e.g. for the tab the AutofillManager is 49 // delegate is associated with" (e.g. for the tab the AutofillManager is
42 // attached to). 50 // attached to).
43 class AutofillManagerDelegate { 51 class AutofillManagerDelegate {
44 public: 52 public:
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 virtual void ShowPasswordGenerationBubble( 84 virtual void ShowPasswordGenerationBubble(
77 const gfx::Rect& bounds, 85 const gfx::Rect& bounds,
78 const content::PasswordForm& form, 86 const content::PasswordForm& form,
79 autofill::PasswordGenerator* generator) = 0; 87 autofill::PasswordGenerator* generator) = 0;
80 88
81 // Causes the dialog for request autocomplete feature to be shown. 89 // Causes the dialog for request autocomplete feature to be shown.
82 virtual void ShowRequestAutocompleteDialog( 90 virtual void ShowRequestAutocompleteDialog(
83 const FormData& form, 91 const FormData& form,
84 const GURL& source_url, 92 const GURL& source_url,
85 const content::SSLStatus& ssl_status, 93 const content::SSLStatus& ssl_status,
94 const AutofillMetrics& metric_logger,
95 DialogRequester requester,
86 const base::Callback<void(const FormStructure*)>& callback) = 0; 96 const base::Callback<void(const FormStructure*)>& callback) = 0;
87 97
88 // Called when the dialog for request autocomplete closes. 98 // Called when the dialog for request autocomplete closes.
89 virtual void RequestAutocompleteDialogClosed() = 0; 99 virtual void RequestAutocompleteDialogClosed() = 0;
90 }; 100 };
91 101
92 } // namespace autofill 102 } // namespace autofill
93 103
94 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_DELEGATE_H_ 104 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698