[Autofill] Add UMA timing metrics for requestAutocomplete dialog.

chrome/browser/autofill/autofill_manager_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_DELEGATE_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_DELEGATE_H_
 
 #include "base/callback_forward.h"
 
 namespace autofill {
 class PasswordGenerator;
 }
 
 namespace content {
 class BrowserContext;
 struct PasswordForm;
 struct SSLStatus;
 }
 
 namespace gfx {
 class Rect;
 }
 
+class AutofillMetrics;
 class FormStructure;
 class GURL;
 class InfoBarService;
 class PrefServiceBase;
 class Profile;
 class ProfileSyncServiceBase;
 
 struct FormData;
 
 namespace autofill {
 
+enum AutocompleteDialogRequester {
+  // Requested by the Autocheckout feature.
+  AUTOCOMPLETE_DIALOG_REQUESTER_AUTOCHECKOUT,
+  // Requested by the requestAutocomplete feature.
+  AUTOCOMPLETE_DIALOG_REQUESTER_REQUEST_AUTOCOMPLETE,
+};

[Ilya Sherman, 2013/02/01 09:55:17]

These names are rather ickily long.  Should I drop the "autocomplete" prefix? 
Any suggestions for even better/shorter names?

[Dan Beam, 2013/02/01 17:17:28]

I think just REQUESTER_ is enough, that's what I did in my patch.

[Ilya Sherman, 2013/02/02 01:22:13]

Compromised by going with DIALOG_REQUESTER_, which seems to look ok in the
contexts where it's used.

+
 // A delegate interface that needs to be supplied to AutofillManager
 // by the embedder.
 //
 // Each delegate instance is associated with a given context within
 // which an AutofillManager is used (e.g. a single tab), so when we
 // say "for the delegate" below, we mean "in the execution context the
 // delegate is associated with" (e.g. for the tab the AutofillManager is
 // attached to).
 class AutofillManagerDelegate {
  public:
@@ skipping 31 matching lines @@
   virtual void ShowPasswordGenerationBubble(
       const gfx::Rect& bounds,
       const content::PasswordForm& form,
       autofill::PasswordGenerator* generator) = 0;
 
   // Causes the dialog for request autocomplete feature to be shown.
   virtual void ShowRequestAutocompleteDialog(
       const FormData& form,
       const GURL& source_url,
       const content::SSLStatus& ssl_status,
+      const AutofillMetrics& metric_logger,
+      AutocompleteDialogRequester requester,
       const base::Callback<void(const FormStructure*)>& callback) = 0;
 
   // Called when the dialog for request autocomplete closes.
   virtual void RequestAutocompleteDialogClosed() = 0;
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_DELEGATE_H_