Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 12091081: [Sync] Add full history sync experiment (Closed)

Created:
7 years, 10 months ago by Nicolas Zea
Modified:
7 years, 10 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Add full history sync experiment Turning the experiment on will enable the full history sync flag, which both updates the history UI to use full history, but also enables the history delete directives sync datatype. BUG=141245 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180037

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M sync/internal_api/public/util/experiments.h View 1 2 chunks +9 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nicolas Zea
PTAL
7 years, 10 months ago (2013-01-31 02:06:29 UTC) #1
rlarocque
LGTM
7 years, 10 months ago (2013-01-31 02:10:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/12091081/2001
7 years, 10 months ago (2013-01-31 19:50:30 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 10 months ago (2013-01-31 19:54:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/12091081/13001
7 years, 10 months ago (2013-01-31 20:39:51 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-31 21:14:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/12091081/13001
7 years, 10 months ago (2013-01-31 21:23:08 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 01:51:52 UTC) #8
Message was sent while issue was closed.
Change committed as 180037

Powered by Google App Engine
This is Rietveld 408576698