Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12091033: Relanding "Add apk for running content_browsertests" (Closed)

Created:
7 years, 10 months ago by nilesh
Modified:
7 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews, sadrul, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jochen+watch_chromium.org, Mark Mentovai
Visibility:
Public.

Description

Relanding "Add apk for running content_browsertests" Revert "Revert 179189" This reverts commit 5844ab0c6a41cc9d306f8c355cc7ceb5e290cbb1. Original CL:https://codereview.chromium.org/12047068/ was reverted as we failed to update the bot scripts with the new package name for content_shell_apk TBR=mark@chromium.org,jam@chromium.org BUG=138275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179428

Patch Set 1 #

Patch Set 2 : Updates to package name in buildbot scripts. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -507 lines) Patch
M base/message_loop.h View 1 chunk +4 lines, -3 lines 0 comments Download
M base/message_loop.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M base/test/test_support_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/adb_gdb_content_shell View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/adb_kill_content_shell View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/adb_run_content_shell View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/buildbot/bb_device_steps.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/gdb_apk View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/gdb_content_shell View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/java_apk.gypi View 2 chunks +3 lines, -5 lines 0 comments Download
M content/content.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 5 chunks +31 lines, -15 lines 0 comments Download
M content/content_tests.gypi View 4 chunks +24 lines, -7 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/CommandLineTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/content_test_suite_base.cc View 2 chunks +17 lines, -0 lines 0 comments Download
A + content/shell/android/browsertests_apk/AndroidManifest.xml View 1 chunk +4 lines, -4 lines 0 comments Download
A content/shell/android/browsertests_apk/content_browser_tests_android.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A + content/shell/android/browsertests_apk/res/layout/test_activity.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java View 1 chunk +46 lines, -0 lines 0 comments Download
A + content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 2 chunks +3 lines, -7 lines 0 comments Download
D content/shell/android/java/AndroidManifest.xml View 1 chunk +0 lines, -72 lines 0 comments Download
A + content/shell/android/java/res/drawable/progress.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/shell/android/java/res/layout/shell_view.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/shell/android/java/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
D content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java View 1 chunk +0 lines, -214 lines 0 comments Download
D content/shell/android/java/src/org/chromium/content_shell/ContentShellApplication.java View 1 chunk +0 lines, -35 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ShellManager.java View 2 chunks +3 lines, -2 lines 0 comments Download
M content/shell/android/javatests/AndroidManifest.xml View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell/ContentShellTestBase.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell/ContentShellUrlTest.java View 1 chunk +1 line, -0 lines 0 comments Download
D content/shell/android/res/drawable/progress.xml View 1 chunk +0 lines, -13 lines 0 comments Download
D content/shell/android/res/layout/content_shell_activity.xml View 1 chunk +0 lines, -14 lines 0 comments Download
D content/shell/android/res/layout/shell_view.xml View 1 chunk +0 lines, -48 lines 0 comments Download
D content/shell/android/res/values/strings.xml View 1 chunk +0 lines, -11 lines 0 comments Download
A + content/shell/android/shell_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/android/shell_apk/res/layout/content_shell_activity.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 4 chunks +4 lines, -3 lines 0 comments Download
A + content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/android/shell_jni_registrar.h View 1 chunk +5 lines, -5 lines 0 comments Download
A content/shell/android/shell_jni_registrar.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M content/shell/android/shell_library_loader.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M content/test/content_test_launcher.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M content/test/run_all_unittests.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/android_browser_finder.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/android_browser_finder_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
nilesh
7 years, 10 months ago (2013-01-29 00:41:55 UTC) #1
Yaron
lgtm
7 years, 10 months ago (2013-01-29 00:52:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12091033/2001
7 years, 10 months ago (2013-01-29 01:44:46 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 02:18:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12091033/2001
7 years, 10 months ago (2013-01-29 16:11:03 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 16:52:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12091033/3056
7 years, 10 months ago (2013-01-29 17:14:26 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 18:07:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12091033/3056
7 years, 10 months ago (2013-01-29 19:34:34 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-01-29 21:56:00 UTC) #10
Message was sent while issue was closed. 
Change committed as 179428

Powered by Google App Engine
This is Rietveld 408576698