Show an icon to launch Chrome (chrome_app) on the Windows App Launcher.

Show an icon to launch Chrome (chrome_app) on the Windows App Launcher.

BUG=168954
TEST=Icon to launch chrome/chromium should appear on the windows app launcher.
     Behaviour on ChromeOS/ash should not change.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180596

[benwells, 2013-02-01 04:16:09]

lgtm, provided it does not change behavior on chromeos.

https://codereview.chromium.org/12090110/diff/1/chrome/browser/browser_resour...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/12090110/diff/1/chrome/browser/browser_resour...
chrome/browser/browser_resources.grd:233: <if
expr="pp_ifdef('enable_app_list')">
Are these meant to go in alphabetical order or something? This ordering seems
random.

[tapted, 2013-02-01 05:02:15]

I found a case where it would trip up, when Chrome is not the default browser.
Please take a look at the change in

https://codereview.chromium.org/12090110/diff/4001/chrome/browser/ui/views/ap...


I'll do some checks on ChromeOS before roping in an OWNER for
chrome[/browser/browser_resources.gyp]

https://codereview.chromium.org/12090110/diff/1/chrome/browser/browser_resour...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/12090110/diff/1/chrome/browser/browser_resour...
chrome/browser/browser_resources.grd:233: <if
expr="pp_ifdef('enable_app_list')">
On 2013/02/01 04:16:09, benwells wrote:
> Are these meant to go in alphabetical order or something? This ordering seems
> random.

This file is pretty random, but there are hints of alphabetical ordering. I've
moved it up to the "C" section.

[benwells, 2013-02-01 05:12:41]

On 2013/02/01 05:02:15, tapted wrote:
> I found a case where it would trip up, when Chrome is not the default browser.
> Please take a look at the change in
> 
>
https://codereview.chromium.org/12090110/diff/4001/chrome/browser/ui/views/ap...
> 
> 
> I'll do some checks on ChromeOS before roping in an OWNER for
> chrome[/browser/browser_resources.gyp]
> 
>
https://codereview.chromium.org/12090110/diff/1/chrome/browser/browser_resour...
> File chrome/browser/browser_resources.grd (right):
> 
>
https://codereview.chromium.org/12090110/diff/1/chrome/browser/browser_resour...
> chrome/browser/browser_resources.grd:233: <if
> expr="pp_ifdef('enable_app_list')">
> On 2013/02/01 04:16:09, benwells wrote:
> > Are these meant to go in alphabetical order or something? This ordering
seems
> > random.
> 
> This file is pretty random, but there are hints of alphabetical ordering. I've
> moved it up to the "C" section.

still lgtm

[tapted, 2013-02-04 02:15:49]

+sky, for OWNERS. Could you please take a look at

- c/b/browser_resources.grd
- c/b/resources/chrome_app/manifest.json change


On 2013/02/01 05:02:15, tapted wrote:
> I'll do some checks on ChromeOS

Checked on ChromeOS - looks good.

Note re: USE_ASH -> ENABLE_APP_LIST from build/common.gypi, ENABLE_APP_LIST is
defined via

          ['use_ash==1 or OS=="win" or OS=="mac"', {
            'enable_app_list%': 1,

(so I didn't put an `||` into the #if defined..)

[sky, 2013-02-04 15:26:19]

LGTM

[commit-bot: I haz the power, 2013-02-04 22:44:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/12090110/4001

[commit-bot: I haz the power, 2013-02-05 01:29:36]

Change committed as 180596