Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 12090098: Tapping on omnibox should select all text. (Closed)

Created:
7 years, 10 months ago by varunjain
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, James Su
Visibility:
Public.

Description

Tapping on omnibox should select all text. BUG=166447 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180075

Patch Set 1 #

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
varunjain
7 years, 10 months ago (2013-01-31 21:54:56 UTC) #1
sky
LGTM
7 years, 10 months ago (2013-01-31 23:57:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/12090098/2001
7 years, 10 months ago (2013-02-01 00:23:58 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 04:53:42 UTC) #4
Message was sent while issue was closed.
Change committed as 180075

Powered by Google App Engine
This is Rietveld 408576698