Split DumpWithoutCrashing() into a separate file

Split DumpWithoutCrashing() into a separate file

This will allow nacl_helper to link against breakpad_linux.cc (which
calls SetDumpWithoutCrashingFunction()) without pulling in the rest of
logging_chrome.cc, which depends on logging code generated for all IPC
messages which we don't want to pull into nacl_helper.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2096
TEST=build


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180057

[Lei Zhang, 2013-01-31 21:56:22]

lgtm with green bots.

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
File chrome/common/dump_without_crashing.cc (right):

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
chrome/common/dump_without_crashing.cc:5: #include "build/build_config.h"
this should go in the header file, since that uses defined(OS_MACOSX).

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
chrome/common/dump_without_crashing.cc:23: }  // anonymous namespace
nit: just // namespace

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
File chrome/common/dump_without_crashing.h (right):

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
chrome/common/dump_without_crashing.h:5: #ifndef
CHROME_COMMON_DUMP_WITHOUT_CRASHING_H__
nit: one underscore at the end. I realize logging_chrome.h is wrong too.

https://codereview.chromium.org/12090096/diff/2003/chrome/common/logging_chro...
File chrome/common/logging_chrome.cc (right):

https://codereview.chromium.org/12090096/diff/2003/chrome/common/logging_chro...
chrome/common/logging_chrome.cc:95: DumpWithoutCrashing();
logging::DumpWithoutCrashing();

[Mark Seaborn, 2013-01-31 23:09:25]

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
File chrome/common/dump_without_crashing.cc (right):

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
chrome/common/dump_without_crashing.cc:5: #include "build/build_config.h"
On 2013/01/31 21:56:22, Lei Zhang wrote:
> this should go in the header file, since that uses defined(OS_MACOSX).

Done.

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
chrome/common/dump_without_crashing.cc:23: }  // anonymous namespace
On 2013/01/31 21:56:22, Lei Zhang wrote:
> nit: just // namespace

Done.

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
File chrome/common/dump_without_crashing.h (right):

https://codereview.chromium.org/12090096/diff/2003/chrome/common/dump_without...
chrome/common/dump_without_crashing.h:5: #ifndef
CHROME_COMMON_DUMP_WITHOUT_CRASHING_H__
On 2013/01/31 21:56:22, Lei Zhang wrote:
> nit: one underscore at the end. I realize logging_chrome.h is wrong too.

Done.

https://codereview.chromium.org/12090096/diff/2003/chrome/common/logging_chro...
File chrome/common/logging_chrome.cc (right):

https://codereview.chromium.org/12090096/diff/2003/chrome/common/logging_chro...
chrome/common/logging_chrome.cc:95: DumpWithoutCrashing();
On 2013/01/31 21:56:22, Lei Zhang wrote:
> logging::DumpWithoutCrashing();

Done.

[commit-bot: I haz the power, 2013-01-31 23:18:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mseaborn@chromium.org/12090096/4002

[commit-bot: I haz the power, 2013-02-01 03:37:28]

Change committed as 180057