Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 12090066: [content shell] ShellRenderProcessObserver no longer depends on WebTestInterfaces. (Closed)

Created:
7 years, 10 months ago by marja
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] ShellRenderProcessObserver no longer depends on WebTestInterfaces. R=jochen BUG=173079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179635

Patch Set 1 #

Patch Set 2 : disable tests which depend on eventsender #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -113 lines) Patch
M content/browser/fileapi/blob_layout_browsertest.cc View 1 4 chunks +27 lines, -63 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 1 chunk +3 lines, -7 lines 0 comments Download
M content/shell/shell_content_renderer_client.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/shell/shell_content_renderer_client.cc View 3 chunks +17 lines, -25 lines 0 comments Download
M content/shell/shell_render_process_observer.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/shell/shell_render_process_observer.cc View 6 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
marja
7 years, 10 months ago (2013-01-30 09:41:32 UTC) #1
jochen (gone - plz use gerrit)
Can you check that the layout tests that fail are failing because of stuff like ...
7 years, 10 months ago (2013-01-30 10:07:03 UTC) #2
marja
done; they all seemed to depend on eventsender
7 years, 10 months ago (2013-01-30 10:29:29 UTC) #3
jochen (gone - plz use gerrit)
lgtm kinuko, fyi
7 years, 10 months ago (2013-01-30 10:36:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/12090066/11001
7 years, 10 months ago (2013-01-30 10:38:53 UTC) #5
commit-bot: I haz the power
Presubmit check for 12090066-11001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-01-30 10:38:56 UTC) #6
kinuko
lgtm
7 years, 10 months ago (2013-01-30 10:41:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/12090066/11001
7 years, 10 months ago (2013-01-30 10:44:23 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-01-30 15:05:26 UTC) #9
Message was sent while issue was closed.
Change committed as 179635

Powered by Google App Engine
This is Rietveld 408576698