Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 12090062: Enable profile switching for standalone App Launcher via the Settings App. (Closed)

Created:
7 years, 10 months ago by koz (OOO until 15th September)
Modified:
7 years, 10 months ago
Reviewers:
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, ben+watch_chromium.org, tfarina, sail+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), pam+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable profile switching for standalone App Launcher via the Settings App. This adds a "Switch user" button to the settings app which when clicked closes the settings app and launches a new app launcher instance for the target profile. Before: http://i.imgur.com/Cp32FTO.png After: http://i.imgur.com/V1y0XBz.png The original LGTMs for this are in https://codereview.chromium.org/11968034 but they are TBR'd here because that CL has an invalid base URL. BUG=166983, 169114, 167094 TEST=Launch chrome with the flag --show-app-list, then switch profiles by launching the settings app and using the "switch user" button. The app list should reappear under the new profile (it's possible to tell profiles apart from what apps are installed). TBR=tapted@chromium.org, benwells@chromium.org, sky@chromium.org, estade@chromium.org, xiyuan@chromium.org, sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180346 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180388

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix compile #

Patch Set 4 : rebase #

Patch Set 5 : put call to GetAppListProfilePath() behind an #ifdef (it's not defined on linux) #

Patch Set 6 : fix compiles #

Patch Set 7 : browser:: -> chrome:: #

Patch Set 8 : fix chrome #

Patch Set 9 : fix extension_install_ui_default #

Patch Set 10 : more tweaking #

Patch Set 11 : fix chromeos interactive_ui_tests #

Patch Set 12 : remove logging #

Patch Set 13 : #include file_path #

Patch Set 14 : rebase #

Patch Set 15 : disable tests on aura #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -103 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +33 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options_page.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options_settings_app.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +77 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +28 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_util.cc View 1 2 3 4 5 6 7 8 9 1 chunk +35 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 2 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 1 2 3 4 5 6 7 8 9 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/app_list/app_list_controller_cocoa.mm View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.h View 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +14 lines, -18 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/app_list_controller_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 10 chunks +212 lines, -38 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 3 chunks +27 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/1
7 years, 10 months ago (2013-01-30 03:25:04 UTC) #1
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/app_list/app_list_view_delegate.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-01-30 03:25:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/2002
7 years, 10 months ago (2013-01-30 04:00:02 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on win_rel HTTP Error 400: Bad Request
7 years, 10 months ago (2013-01-30 04:25:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/9002
7 years, 10 months ago (2013-01-30 04:38:30 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-30 05:11:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/32
7 years, 10 months ago (2013-01-30 23:36:25 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-31 01:29:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/6010
7 years, 10 months ago (2013-01-31 05:29:22 UTC) #9
commit-bot: I haz the power
Failed to trigger a try job on linux_chromeos HTTP Error 400: Bad Request
7 years, 10 months ago (2013-01-31 07:30:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/12005
7 years, 10 months ago (2013-01-31 07:30:40 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-31 08:18:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/13039
7 years, 10 months ago (2013-01-31 10:08:29 UTC) #13
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-31 10:46:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/5012
7 years, 10 months ago (2013-02-01 02:09:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/12063
7 years, 10 months ago (2013-02-01 04:55:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/12063
7 years, 10 months ago (2013-02-03 11:36:06 UTC) #17
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-03 12:10:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/12063
7 years, 10 months ago (2013-02-03 21:40:07 UTC) #19
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-03 22:13:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/34002
7 years, 10 months ago (2013-02-03 23:20:58 UTC) #21
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/views/app_list/app_list_controller_win.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-02-04 02:23:13 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12090062/42003
7 years, 10 months ago (2013-02-04 08:42:49 UTC) #23
commit-bot: I haz the power
7 years, 10 months ago (2013-02-04 11:55:55 UTC) #24
Message was sent while issue was closed.
Change committed as 180388

Powered by Google App Engine
This is Rietveld 408576698