Validator_ragel: REX prefix support in gen_dfa.py.

Validator_ragel: REX prefix support in gen_dfa.py.


BUG= https://code.google.com/p/nativeclient/issues/detail?id=3232
TEST= ./scons run_gen_dfa_test

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10674

[Vlad Shcherbina, 2013-01-29 13:50:57]

Please take a look.

[khim, 2013-01-29 14:07:01]

https://codereview.chromium.org/12090047/diff/2001/src/trusted/validator_rage...
File src/trusted/validator_ragel/gen_dfa.py (right):

https://codereview.chromium.org/12090047/diff/2001/src/trusted/validator_rage...
src/trusted/validator_ragel/gen_dfa.py:363: self.opcodes[0] == '0x8f' and
self.opcodes[1] != '/0')
I don't think you need to check self.opcodes[1] here.

"pop Er" is "0x8f /0" and "pop Ew" is "data16 0x8f /0"...

https://codereview.chromium.org/12090047/diff/2001/src/trusted/validator_rage...
src/trusted/validator_ragel/gen_dfa.py:489: assert not instruction.IsVexOrXop()
Why not? Where and how do you plan to print vzeroall, vzeroupper, etc?

[Vlad Shcherbina, 2013-01-29 14:50:37]

https://codereview.chromium.org/12090047/diff/2001/src/trusted/validator_rage...
File src/trusted/validator_ragel/gen_dfa.py (right):

https://codereview.chromium.org/12090047/diff/2001/src/trusted/validator_rage...
src/trusted/validator_ragel/gen_dfa.py:363: self.opcodes[0] == '0x8f' and
self.opcodes[1] != '/0')
On 2013/01/29 14:07:01, khim wrote:
> I don't think you need to check self.opcodes[1] here.
> 
> "pop Er" is "0x8f /0" and "pop Ew" is "data16 0x8f /0"...

Changed to what I think is more straightforward check.

https://codereview.chromium.org/12090047/diff/2001/src/trusted/validator_rage...
src/trusted/validator_ragel/gen_dfa.py:489: assert not instruction.IsVexOrXop()
On 2013/01/29 14:07:01, khim wrote:
> Why not? Where and how do you plan to print vzeroall, vzeroupper, etc?

Right, marked as 'not implemented'.

[halyavin, 2013-01-29 15:15:56]

lgtm

https://chromiumcodereview.appspot.com/12090047/diff/2001/src/trusted/validat...
File src/trusted/validator_ragel/gen_dfa.py (right):

https://chromiumcodereview.appspot.com/12090047/diff/2001/src/trusted/validat...
src/trusted/validator_ragel/gen_dfa.py:385: def _PrintRexPrefix(self,
instruction):
"""Print machine for rex prefix."""

https://chromiumcodereview.appspot.com/12090047/diff/2001/src/trusted/validat...
src/trusted/validator_ragel/gen_dfa.py:397: def _PrintOpcode(self, instruction):
"""Print machine for opcode."""