Issue 12090003: Remove ".." from PathService take #2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12090003: Remove ".." from PathService take #2. (Closed)

Created:
7 years, 11 months ago by M-A Ruel

Modified:
7 years, 11 months ago

Reviewers:
Mark Mentovai, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove ".." from PathService take #2. Hook directly into PathService::Get() and only convert to an absolute path when ".." is found in the path. Otherwise leave it as-is. In particular, this won't trigger when the path is simply relative, like "./unit_tests". This is necessary to make most test cases pass but this has the advatange of not triggering in the common case for Google Chrome. R=cpu@chromium.org,mark@chromium.org BUG=168890 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179042