Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 12089100: Delete flag --enable-css-transform-pinch. (Closed)

Created:
7 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, danakj, wjmaclean
Visibility:
Public.

Description

Delete flag --enable-css-transform-pinch. This flag activated a different coordinate space for pinch that was used only on Android. Android has now converted to desktop pinch and this old mode is already starting to break, so we should delete this flag. I'll follow up with further cleanup later. I also set apply_page_scale_factor_in_compositor to true in all cases in order to avoid needing any further support for the codepaths where it's false (it should be a no-op when pinch is disabled in principle). NOTRY=true BUG=173534 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180048

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -34 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -15 lines 1 comment Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
aelias_OOO_until_Jul13
Hi Antoine, Just a quick cleanup of a cruft flag to avoid confusing people.
7 years, 10 months ago (2013-02-01 00:12:35 UTC) #1
piman
https://codereview.chromium.org/12089100/diff/1/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/12089100/diff/1/content/browser/web_contents/web_contents_impl.cc#newcode651 content/browser/web_contents/web_contents_impl.cc:651: prefs.apply_page_scale_factor_in_compositor = true; apply_page_scale_factor_in_compositor was only set when kEnablePinch ...
7 years, 10 months ago (2013-02-01 00:25:09 UTC) #2
aelias_OOO_until_Jul13
Yes, I intended to change it. It affects the treatment of pageScaleFactor in WebKit and ...
7 years, 10 months ago (2013-02-01 00:34:11 UTC) #3
piman
OK, LGTM if you know what you're doing
7 years, 10 months ago (2013-02-01 02:08:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12089100/1
7 years, 10 months ago (2013-02-01 02:34:02 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 03:02:21 UTC) #6
Message was sent while issue was closed.
Change committed as 180048

Powered by Google App Engine
This is Rietveld 408576698