Move API functions registrations out of ExtensionFunctionRegistry.

Move API functions registrations out of ExtensionFunctionRegistry.

JSON schema compiler automatically registers api functions in generated_api.cc files for the JSON files specified as schema_files in api.gyp. JSON schema compiler generates code in specific namespace, function names and file paths as per json files.

BUG=159265
TBR=mirandac@chromium.org
TBR=ben@chromium.org
TBR=kalman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182423

[SanjoyPal, 2013-01-30 03:40:34]

There are few json file names with experimental_ prefix which generate function
names/file names with Experimental prefix. Should we fix this in json schema
compiler side?

[SanjoyPal, 2013-01-30 04:01:40]

Its already handled in json compiler side. Please ignore the above comment.

[not at google - send to devlin, 2013-01-30 04:04:43]

Nice. You can also delete the references to them in extension_api.cc and
extensions_api_resources.grd.

And yep we should make the schema compiler not add the Experimental prefix at
some point.

[Yoyo Zhou, 2013-01-30 21:35:55]

Sweet. LGTM.

[SanjoyPal, 2013-02-01 01:55:38]

Move API functions registrations out of ExtensionFunctionRegistry.

BUG=159265

[SanjoyPal, 2013-02-01 02:18:23]

Added some more json files to api.gyp. Done some modifications in json files and
cpp_util.py. Please review if the changes are fine before proceeding for the
rest.

[Yoyo Zhou, 2013-02-01 19:57:18]

https://codereview.chromium.org/12089062/diff/4005/tools/json_schema_compiler...
File tools/json_schema_compiler/cpp_util.py (right):

https://codereview.chromium.org/12089062/diff/4005/tools/json_schema_compiler...
tools/json_schema_compiler/cpp_util.py:34: new_s = re.sub(r'[^a-zA-Z0-9]',
'.',s)
If we're going to go the regex route, we should go all the way. Use re.split
instead of str.split below.

[not at google - send to devlin, 2013-02-01 19:59:01]

https://codereview.chromium.org/12089062/diff/4005/tools/json_schema_compiler...
File tools/json_schema_compiler/cpp_util.py (right):

https://codereview.chromium.org/12089062/diff/4005/tools/json_schema_compiler...
tools/json_schema_compiler/cpp_util.py:35: return '_'.join([x[0].upper() + x[1:]
for x in new_s.split('.')])
why this change anyway?

[SanjoyPal, 2013-02-01 20:16:28]

https://codereview.chromium.org/12089062/diff/4005/tools/json_schema_compiler...
File tools/json_schema_compiler/cpp_util.py (right):

https://codereview.chromium.org/12089062/diff/4005/tools/json_schema_compiler...
tools/json_schema_compiler/cpp_util.py:35: return '_'.join([x[0].upper() + x[1:]
for x in new_s.split('.')])
On 2013/02/01 19:59:02, kalman wrote:
> why this change anyway?
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/common/extensions/a...

Here, the enums generated are TYPE_HISTOGRAM-LOG
and TYPE_HISTOGRAM-LINEAR

[SanjoyPal, 2013-02-05 20:59:50]

PTAL. Thanks

[Yoyo Zhou, 2013-02-05 21:12:13]

On 2013/02/05 20:59:50, SanjoyPal wrote:
> PTAL. Thanks

You didn't address my comment on cpp_util.py.

[SanjoyPal, 2013-02-05 21:45:33]

Updated. Please review.

https://codereview.chromium.org/12089062/diff/4005/tools/json_schema_compiler...
File tools/json_schema_compiler/cpp_util.py (right):

https://codereview.chromium.org/12089062/diff/4005/tools/json_schema_compiler...
tools/json_schema_compiler/cpp_util.py:34: new_s = re.sub(r'[^a-zA-Z0-9]',
'.',s)
On 2013/02/01 19:57:18, Yoyo Zhou wrote:
> If we're going to go the regex route, we should go all the way. Use re.split
> instead of str.split below.

Done.

[Yoyo Zhou, 2013-02-05 23:42:13]

https://codereview.chromium.org/12089062/diff/43015/tools/json_schema_compile...
File tools/json_schema_compiler/cpp_util.py (right):

https://codereview.chromium.org/12089062/diff/43015/tools/json_schema_compile...
tools/json_schema_compiler/cpp_util.py:35: return '_'.join([x[0].upper() + x[1:]
for x in re.split('\.', new_s)])
No, the point of using re.split is that you don't need to use re.sub. Please see
the documentation on re.split in the Python manual.

[SanjoyPal, 2013-02-06 00:47:20]

Done.

https://codereview.chromium.org/12089062/diff/43015/tools/json_schema_compile...
File tools/json_schema_compiler/cpp_util.py (right):

https://codereview.chromium.org/12089062/diff/43015/tools/json_schema_compile...
tools/json_schema_compiler/cpp_util.py:35: return '_'.join([x[0].upper() + x[1:]
for x in re.split('\.', new_s)])
On 2013/02/05 23:42:13, Yoyo Zhou wrote:
> No, the point of using re.split is that you don't need to use re.sub. Please
see
> the documentation on re.split in the Python manual.

Done.

[Yoyo Zhou, 2013-02-11 19:42:04]

LGTM

[Yoyo Zhou, 2013-02-11 19:43:45]

On 2013/02/11 19:42:04, Yoyo Zhou wrote:
> LGTM

And please update the changelist description to be more descriptive. You should
add another paragraph below the 1-line summary saying how it is you're doing the
1-line summary.

[commit-bot: I haz the power, 2013-02-11 20:07:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/12089062/37019

[commit-bot: I haz the power, 2013-02-11 20:07:27]

Failed to apply patch for
chrome/browser/chromeos/extensions/echo_private_api.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chromeos/extensions/echo_private_api.cc
  Hunk #1 FAILED at 40.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/chromeos/extensions/echo_private_api.cc.rej

Patch:       chrome/browser/chromeos/extensions/echo_private_api.cc
Index: chrome/browser/chromeos/extensions/echo_private_api.cc
===================================================================
--- chrome/browser/chromeos/extensions/echo_private_api.cc	(revision 179687)
+++ chrome/browser/chromeos/extensions/echo_private_api.cc	(working copy)
@@ -40,13 +40,13 @@
 }  // namespace
 
 
-GetRegistrationCodeFunction::GetRegistrationCodeFunction() {
-}
+EchoPrivateGetRegistrationCodeFunction::
+    EchoPrivateGetRegistrationCodeFunction() {}
 
-GetRegistrationCodeFunction::~GetRegistrationCodeFunction() {
-}
+EchoPrivateGetRegistrationCodeFunction::
+    ~EchoPrivateGetRegistrationCodeFunction() {}
 
-bool GetRegistrationCodeFunction::RunImpl() {
+bool EchoPrivateGetRegistrationCodeFunction::RunImpl() {
   std::string type;
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &type));
   SetResult(GetValueForRegistrationCodeType(type));

[commit-bot: I haz the power, 2013-02-11 20:51:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/12089062/44104

[commit-bot: I haz the power, 2013-02-11 20:52:12]

Failed to apply patch for chrome/browser/chromeos/power/suspend_observer.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chromeos/power/suspend_observer.cc
  Hunk #1 FAILED at 5.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/chromeos/power/suspend_observer.cc.rej

Patch:       chrome/browser/chromeos/power/suspend_observer.cc
Index: chrome/browser/chromeos/power/suspend_observer.cc
===================================================================
--- chrome/browser/chromeos/power/suspend_observer.cc	(revision 179687)
+++ chrome/browser/chromeos/power/suspend_observer.cc	(working copy)
@@ -5,7 +5,7 @@
 #include "chrome/browser/chromeos/power/suspend_observer.h"
 
 #include "chrome/browser/chromeos/login/user_manager.h"
-#include "chrome/browser/extensions/system/system_api.h"
+#include "chrome/browser/extensions/api/system_private/system_private_api.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"

[commit-bot: I haz the power, 2013-02-12 01:59:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/12089062/50026

[commit-bot: I haz the power, 2013-02-12 04:51:11]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-02-12 18:55:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/12089062/66001

[commit-bot: I haz the power, 2013-02-13 18:52:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/12089062/66001

[commit-bot: I haz the power, 2013-02-13 19:29:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/12089062/66001

[commit-bot: I haz the power, 2013-02-14 08:42:55]

Change committed as 182423