Chromium Code Reviews
Help | Chromium Project | Sign in
(76)

Issue 12089037: Add management.uninstallSelf to API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by calamity
Modified:
1 year, 2 months ago
Reviewers:
koz
CC:
chromium-reviews_chromium.org, Aaron Boodman, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add management.uninstallSelf to API

Let extensions/apps uninstall themselves without requiring the management
permission.

BUG=166546
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179506

Patch Set 1 #

Patch Set 2 : modify api docs #

Total comments: 4

Patch Set 3 : rework #

Patch Set 4 : sync #

Patch Set 5 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -26 lines) Lint Patch
M chrome/browser/extensions/api/management/management_api.h View 1 2 3 2 chunks +31 lines, -6 lines 0 comments ? errors Download
M chrome/browser/extensions/api/management/management_api.cc View 1 2 3 3 chunks +46 lines, -17 lines 0 comments ? errors Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/common/extensions/api/management.json View 1 chunk +24 lines, -0 lines 0 comments ? errors Download
M chrome/common/extensions/docs/templates/intros/management.html View 1 1 chunk +3 lines, -3 lines 0 comments ? errors Download
M chrome/common/extensions/permissions/permission_set.cc View 1 chunk +1 line, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 11
calamity
1 year, 2 months ago #1
koz
lgtm https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/api/management/management_api.cc File chrome/browser/extensions/api/management/management_api.cc (right): https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/api/management/management_api.cc#newcode588 chrome/browser/extensions/api/management/management_api.cc:588: ManagementUninstallSelfFunction::ManagementUninstallSelfFunction() { The definitions of functions for a ...
1 year, 2 months ago #2
calamity
https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/api/management/management_api.cc File chrome/browser/extensions/api/management/management_api.cc (right): https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/api/management/management_api.cc#newcode588 chrome/browser/extensions/api/management/management_api.cc:588: ManagementUninstallSelfFunction::ManagementUninstallSelfFunction() { On 2013/01/29 05:20:26, koz wrote: > The ...
1 year, 2 months ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/12089037/9001
1 year, 2 months ago #4
I haz the power (commit-bot)
Failed to apply patch for chrome/browser/extensions/api/management/management_api.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
1 year, 2 months ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/12089037/11001
1 year, 2 months ago #6
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
1 year, 2 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/12089037/11001
1 year, 2 months ago #8
I haz the power (commit-bot)
Failed to apply patch for chrome/browser/extensions/extension_function_histogram_value.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
1 year, 2 months ago #9
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/12089037/3010
1 year, 2 months ago #10
I haz the power (commit-bot)
1 year, 2 months ago #11
Message was sent while issue was closed.
Change committed as 179506
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6