Add management.uninstallSelf to API

Add management.uninstallSelf to API

Let extensions/apps uninstall themselves without requiring the management
permission.

BUG=166546
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179506

[koz (OOO until 15th September), 2013-01-29 05:20:26]

lgtm

https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/management/management_api.cc (right):

https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/management/management_api.cc:588:
ManagementUninstallSelfFunction::ManagementUninstallSelfFunction() {
The definitions of functions for a class should all be contiguous (ie: these
definitions shouldn't come in the middle of the ManagementUninstallFunction
definitions).

https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/management/management_api.h (right):

https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/management/management_api.h:152: class
ManagementUninstallSelfFunction : public ManagementUninstallFunction {
It's not common for functions to subclass each other like this. More common
would be to have a ManagementUninstallFunctionBase class and then have two
subclasses ManagementUninstallFunction and ManagementUninstallSelfFunction.

Would you mind refactoring this code to be like that? In the base class you
could have an Uninstall(const std::string& extension_id, bool
show_confirm_dialog) and remove the need for a set_extension_id() method, too.

[calamity, 2013-01-29 06:06:16]

https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/management/management_api.cc (right):

https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/management/management_api.cc:588:
ManagementUninstallSelfFunction::ManagementUninstallSelfFunction() {
On 2013/01/29 05:20:26, koz wrote:
> The definitions of functions for a class should all be contiguous (ie: these
> definitions shouldn't come in the middle of the ManagementUninstallFunction
> definitions).

Done.

https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/management/management_api.h (right):

https://codereview.chromium.org/12089037/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/management/management_api.h:152: class
ManagementUninstallSelfFunction : public ManagementUninstallFunction {
On 2013/01/29 05:20:26, koz wrote:
> It's not common for functions to subclass each other like this. More common
> would be to have a ManagementUninstallFunctionBase class and then have two
> subclasses ManagementUninstallFunction and ManagementUninstallSelfFunction.
> 
> Would you mind refactoring this code to be like that? In the base class you
> could have an Uninstall(const std::string& extension_id, bool
> show_confirm_dialog) and remove the need for a set_extension_id() method, too.

Done.

[commit-bot: I haz the power, 2013-01-29 06:10:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/12089037/9001

[commit-bot: I haz the power, 2013-01-29 06:10:35]

Failed to apply patch for
chrome/browser/extensions/api/management/management_api.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/api/management/management_api.h
  Hunk #1 FAILED at 119.
  Hunk #2 succeeded at 147 (offset 2 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/extensions/api/management/management_api.h.rej

Patch:       chrome/browser/extensions/api/management/management_api.h
Index: chrome/browser/extensions/api/management/management_api.h
diff --git a/chrome/browser/extensions/api/management/management_api.h
b/chrome/browser/extensions/api/management/management_api.h
index
07553c88a3a10ea9b972647191276a5f008b4548..edea7b46a10b73f78d0fb68c2282669c22619bf3
100644
--- a/chrome/browser/extensions/api/management/management_api.h
+++ b/chrome/browser/extensions/api/management/management_api.h
@@ -119,22 +119,22 @@ class ManagementSetEnabledFunction : public
AsyncManagementFunction,
   scoped_ptr<ExtensionInstallPrompt> install_prompt_;
 };
 
-class ManagementUninstallFunction : public AsyncManagementFunction,
+class ManagementUninstallFunctionBase : public AsyncManagementFunction,
                           public ExtensionUninstallDialog::Delegate {
  public:
-  DECLARE_EXTENSION_FUNCTION_NAME("management.uninstall");
+  ManagementUninstallFunctionBase();
 
-  ManagementUninstallFunction();
   static void SetAutoConfirmForTest(bool should_proceed);
 
   // ExtensionUninstallDialog::Delegate implementation.
   virtual void ExtensionUninstallAccepted() OVERRIDE;
   virtual void ExtensionUninstallCanceled() OVERRIDE;
 
- private:
-  virtual ~ManagementUninstallFunction();
+ protected:
+  virtual ~ManagementUninstallFunctionBase();
 
-  virtual bool RunImpl() OVERRIDE;
+  bool Uninstall(const std::string& extension_id, bool show_confirm_dialog);
+ private:
 
   // If should_uninstall is true, this method does the actual uninstall.
   // If |show_uninstall_dialog|, then this function will be called by one of
the
@@ -145,6 +145,30 @@ class ManagementUninstallFunction : public
AsyncManagementFunction,
   scoped_ptr<ExtensionUninstallDialog> extension_uninstall_dialog_;
 };
 
+class ManagementUninstallFunction : public ManagementUninstallFunctionBase {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("management.uninstall");
+
+  ManagementUninstallFunction();
+
+ private:
+  virtual ~ManagementUninstallFunction();
+
+  virtual bool RunImpl() OVERRIDE;
+};
+
+class ManagementUninstallSelfFunction : public ManagementUninstallFunctionBase
{
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("management.uninstallSelf");
+
+  ManagementUninstallSelfFunction();
+
+ private:
+  virtual ~ManagementUninstallSelfFunction();
+
+  virtual bool RunImpl() OVERRIDE;
+};
+
 class ManagementEventRouter : public content::NotificationObserver {
  public:
   explicit ManagementEventRouter(Profile* profile);

[commit-bot: I haz the power, 2013-01-29 09:19:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/12089037/11001

[commit-bot: I haz the power, 2013-01-29 10:11:06]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-29 22:31:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/12089037/11001

[commit-bot: I haz the power, 2013-01-29 22:31:06]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 459.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
f9ada07655dc1c936fbd547801ac9cb42b19073b..920dada58de35bdcb6a457f07382827e0af3e307
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -459,6 +459,7 @@ enum HistogramValue {
   WEBVIEW_EXECUTESCRIPT,
   EXPERIMENTAL_NOTIFICATION_UPDATE,
   EXPERIMENTAL_NOTIFICATION_DELETE,
+  MANAGEMENT_UNINSTALLSELF,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-01-29 22:54:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/12089037/3010

[commit-bot: I haz the power, 2013-01-30 02:06:30]

Change committed as 179506