Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 12089029: Adds a backend for increased performance of chromium-build (Closed)

Created:
7 years, 10 months ago by agable
Modified:
7 years, 10 months ago
Reviewers:
M-A Ruel, hinoka
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

Adds a backend for increased performance of chromium-build This CL: a) adds all the backend infrastructure to store rows of data in memory for easy access and fast rendering; b) contains a complete backend updater and data storage mechanism; c) stubs out the backend renderer (which will serve nearly-complete pages to the current frontend); and d) has no effect (yet) on the current frontend. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=180201

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 14

Patch Set 3 : Responding to maruel's comments. #

Total comments: 10

Patch Set 4 : Second round of comments. #

Total comments: 8

Patch Set 5 : Responding to nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -0 lines) Patch
M app.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M app.yaml View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A backends.yaml View 1 chunk +4 lines, -0 lines 0 comments Download
A merger.py View 1 2 3 4 1 chunk +185 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
agable
PTAL This CL has no effect on the actual runnings of the chromium-build app, but ...
7 years, 10 months ago (2013-01-29 00:01:03 UTC) #1
M-A Ruel
https://chromiumcodereview.appspot.com/12089029/diff/2001/app.yaml File app.yaml (right): https://chromiumcodereview.appspot.com/12089029/diff/2001/app.yaml#newcode25 app.yaml:25: - url: /backend/.* You should put all the restricted ...
7 years, 10 months ago (2013-01-29 00:28:20 UTC) #2
agable
Responding to comments inline. https://chromiumcodereview.appspot.com/12089029/diff/2001/app.yaml File app.yaml (right): https://chromiumcodereview.appspot.com/12089029/diff/2001/app.yaml#newcode25 app.yaml:25: - url: /backend/.* Good idea. ...
7 years, 10 months ago (2013-01-29 00:58:47 UTC) #3
M-A Ruel
https://chromiumcodereview.appspot.com/12089029/diff/6003/handler.py File handler.py (right): https://chromiumcodereview.appspot.com/12089029/diff/6003/handler.py#newcode120 handler.py:120: ('/tasks/fetch_pages', FetchPagesAction), Not needed https://chromiumcodereview.appspot.com/12089029/diff/6003/merger.py File merger.py (right): https://chromiumcodereview.appspot.com/12089029/diff/6003/merger.py#newcode15 ...
7 years, 10 months ago (2013-01-31 01:36:58 UTC) #4
agable
Responses inline. https://chromiumcodereview.appspot.com/12089029/diff/6003/handler.py File handler.py (right): https://chromiumcodereview.appspot.com/12089029/diff/6003/handler.py#newcode120 handler.py:120: ('/tasks/fetch_pages', FetchPagesAction), On 2013/01/31 01:36:58, Marc-Antoine Ruel ...
7 years, 10 months ago (2013-02-01 20:15:36 UTC) #5
M-A Ruel
https://chromiumcodereview.appspot.com/12089029/diff/11001/merger.py File merger.py (right): https://chromiumcodereview.appspot.com/12089029/diff/11001/merger.py#newcode5 merger.py:5: import app Ordering; stdlib first, then package-local imports. https://chromiumcodereview.appspot.com/12089029/diff/11001/merger.py#newcode108 ...
7 years, 10 months ago (2013-02-01 22:38:05 UTC) #6
agable
https://chromiumcodereview.appspot.com/12089029/diff/11001/merger.py File merger.py (right): https://chromiumcodereview.appspot.com/12089029/diff/11001/merger.py#newcode5 merger.py:5: import app On 2013/02/01 22:38:05, Marc-Antoine Ruel wrote: > ...
7 years, 10 months ago (2013-02-01 22:50:09 UTC) #7
M-A Ruel
lgtm
7 years, 10 months ago (2013-02-01 22:54:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/12089029/3006
7 years, 10 months ago (2013-02-01 23:07:51 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 23:08:09 UTC) #10
Message was sent while issue was closed.
Change committed as 180201

Powered by Google App Engine
This is Rietveld 408576698