Register autofill sync types on mobile

Register autofill sync types on mobile

This change registers the autofill and autofillProfile sync types on
Android (in addition to desktop platforms).

Also add an AUTOFILL type to ModelTypes.

BUG=174232
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180629

[cjhopman, 2013-01-28 22:49:36]

zea@: *

[Nicolas Zea, 2013-01-29 01:22:23]

https://codereview.chromium.org/12089025/diff/1/chrome/browser/sync/profile_s...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/12089025/diff/1/chrome/browser/sync/profile_s...
chrome/browser/sync/profile_sync_components_factory_impl.cc:123: if
(!command_line_->HasSwitch(switches::kDisableSyncAutofillProfile)) {
Comment about this being enabled by default too

https://codereview.chromium.org/12089025/diff/1/chrome/browser/sync/profile_s...
chrome/browser/sync/profile_sync_components_factory_impl.cc:128: 
remove extra newline

https://codereview.chromium.org/12089025/diff/1/sync/android/java/src/org/chr...
File
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java
(right):

https://codereview.chromium.org/12089025/diff/1/sync/android/java/src/org/chr...
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java:23:
AUTOFILL("AUTOFILL"),
I'm not sure how this enum is used, but should AUTOFILL PROFILE also be added
here? Or is this just user visible types?

[nyquist, 2013-01-31 20:07:52]

https://codereview.chromium.org/12089025/diff/1/sync/android/java/src/org/chr...
File
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java
(right):

https://codereview.chromium.org/12089025/diff/1/sync/android/java/src/org/chr...
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java:23:
AUTOFILL("AUTOFILL"),
On 2013/01/29 01:22:23, Nicolas Zea wrote:
> I'm not sure how this enum is used, but should AUTOFILL PROFILE also be added
> here? Or is this just user visible types?

It is both for user-visible types, and for cacheinvalidation notifications. I
would guess AUTOFILL_PROFILE would be needed for nudges to come in for that
datatype?

[cjhopman, 2013-02-05 01:47:20]

https://codereview.chromium.org/12089025/diff/1/chrome/browser/sync/profile_s...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/12089025/diff/1/chrome/browser/sync/profile_s...
chrome/browser/sync/profile_sync_components_factory_impl.cc:123: if
(!command_line_->HasSwitch(switches::kDisableSyncAutofillProfile)) {
On 2013/01/29 01:22:23, Nicolas Zea wrote:
> Comment about this being enabled by default too

Done.

https://codereview.chromium.org/12089025/diff/1/chrome/browser/sync/profile_s...
chrome/browser/sync/profile_sync_components_factory_impl.cc:128: 
On 2013/01/29 01:22:23, Nicolas Zea wrote:
> remove extra newline

Done.

https://codereview.chromium.org/12089025/diff/1/sync/android/java/src/org/chr...
File
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java
(right):

https://codereview.chromium.org/12089025/diff/1/sync/android/java/src/org/chr...
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java:23:
AUTOFILL("AUTOFILL"),
On 2013/01/31 20:07:52, nyquist wrote:
> On 2013/01/29 01:22:23, Nicolas Zea wrote:
> > I'm not sure how this enum is used, but should AUTOFILL PROFILE also be
added
> > here? Or is this just user visible types?
> 
> It is both for user-visible types, and for cacheinvalidation notifications. I
> would guess AUTOFILL_PROFILE would be needed for nudges to come in for that
> datatype?

Done. Yes, this was needed for cache invalidation.

[Nicolas Zea, 2013-02-05 01:48:28]

lgtm

[commit-bot: I haz the power, 2013-02-05 02:40:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12089025/6001

[commit-bot: I haz the power, 2013-02-05 07:42:18]

Change committed as 180629