Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 12088104: Move DownloadFileOperation to base_operations. (Closed)

Created:
7 years, 10 months ago by hidehiko
Modified:
7 years, 10 months ago
Reviewers:
Lei Zhang, satorux1, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@b148627_download_file_3_test_util
Visibility:
Public.

Description

Move DownloadFileOperation to base_operations. The operation can be shared between GData WAPI and Drive API v2. So, as the preparation of the migration, this moves it and its test to base_operations. Note that the unittest for the moved class is in base_operation_server_unittest.cc. The reason why it is split from the existing base_operation_unittest.cc is that unfortunately the test won't work on Android. The cause is as same as gdata_wapi_operations_unittest/drive_api_operations_unittest. So, disabled it on Android in the same way with them. BUG=148627 TEST=Ran unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180628

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -202 lines) Patch
M chrome/browser/google_apis/base_operations.h View 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/base_operations.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A chrome/browser/google_apis/base_operations_server_unittest.cc View 1 chunk +149 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.h View 1 1 chunk +0 lines, -59 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.cc View 1 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 1 3 chunks +0 lines, -73 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 10 months ago (2013-02-04 07:20:45 UTC) #1
hidehiko
Note: this CL is based on https://codereview.chromium.org/12093107/, which extracts some utilities for testing to test_util.
7 years, 10 months ago (2013-02-04 07:22:05 UTC) #2
satorux1
LGTM +thestig@ for .gypi changes.
7 years, 10 months ago (2013-02-04 07:39:52 UTC) #3
kinaba
LGTM. I thought that test gypi files have per-file OWNER=* hence we can just let ...
7 years, 10 months ago (2013-02-04 07:42:46 UTC) #4
Lei Zhang
On 2013/02/04 07:42:46, kinaba wrote: > LGTM. I thought that test gypi files have per-file ...
7 years, 10 months ago (2013-02-04 19:28:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12088104/7002
7 years, 10 months ago (2013-02-04 19:30:34 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/google_apis/gdata_wapi_operations_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-02-04 19:30:37 UTC) #7
hidehiko
Thank you for your review, and, Lei, thank you for enqueueing this. Rebased and submitting ...
7 years, 10 months ago (2013-02-05 02:15:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12088104/28001
7 years, 10 months ago (2013-02-05 02:16:18 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-05 07:42:04 UTC) #10
Message was sent while issue was closed.
Change committed as 180628

Powered by Google App Engine
This is Rietveld 408576698