Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 12088098: Disable MMX intrinsics in qcms for x64 earlier than MSVC 2012 (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Disable MMX intrinsics in qcms for x64 earlier than MSVC 2012 MMX intrinsics aren't supported on x64 until MSVC 2012. BUG=166496 TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180078

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/qcms/qcms.gyp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12088098/2001
7 years, 10 months ago (2013-02-01 01:12:51 UTC) #1
scottmg
lgtm https://codereview.chromium.org/12088098/diff/2001/third_party/qcms/qcms.gyp File third_party/qcms/qcms.gyp (right): https://codereview.chromium.org/12088098/diff/2001/third_party/qcms/qcms.gyp#newcode40 third_party/qcms/qcms.gyp:40: (OS=="win" and target_arch=="x64" and MSVS_VERSION<"2012")', { items = ...
7 years, 10 months ago (2013-02-01 01:18:42 UTC) #2
jschuh
https://codereview.chromium.org/12088098/diff/2001/third_party/qcms/qcms.gyp File third_party/qcms/qcms.gyp (right): https://codereview.chromium.org/12088098/diff/2001/third_party/qcms/qcms.gyp#newcode40 third_party/qcms/qcms.gyp:40: (OS=="win" and target_arch=="x64" and MSVS_VERSION<"2012")', { On 2013/02/01 01:18:42, ...
7 years, 10 months ago (2013-02-01 01:32:04 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on android_clang_dbg HTTP Error 400: Bad Request
7 years, 10 months ago (2013-02-01 01:51:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12088098/18001
7 years, 10 months ago (2013-02-01 01:53:01 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 05:09:32 UTC) #6
Message was sent while issue was closed.
Change committed as 180078

Powered by Google App Engine
This is Rietveld 408576698