Issue 12088096: Enable the unit tests in src/extensions/ dir

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12088096: Enable the unit tests in src/extensions/ dir (Closed)

Created:
7 years, 10 months ago by Joe Thomas

Modified:
7 years, 10 months ago

Reviewers:
Yoyo Zhou, Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Enable the unit tests in src/extensions/ dir BUG=162530 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180070

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/chrome_tests_unit.gypi	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Joe Thomas

https://codereview.chromium.org/12088096/diff/1/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (left): https://codereview.chromium.org/12088096/diff/1/chrome/chrome_tests_unit.gypi#oldcode41 chrome/chrome_tests_unit.gypi:41: '../extensions/common/url_pattern_set_unittest.cc', Yoyo@ Any reason for keeping these files here? ...

7 years, 10 months ago (2013-01-31 22:53:35 UTC) #1

Yoyo Zhou

LGTM Someone here noticed this bug a while back but never got around to fixing ...

7 years, 10 months ago (2013-01-31 22:57:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12088096/1

7 years, 10 months ago (2013-01-31 23:17:34 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages