Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12088095: Adding didCancelCompositionOnSelectionChange callback. (Closed)

Created:
7 years, 10 months ago by aurimas (slooooooooow)
Modified:
7 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Adding didCancelCompositionOnSelectionChange callback. Adding the Chromium side fix for the WebKit bug https://bugs.webkit.org/show_bug.cgi?id=107737 This fixes a bug where the composition did not get cancelled on JavaScript changes. BUG=164427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
aurimas (slooooooooow)
Hello James, Could you take a look at this CL? Thanks! Aurimas
7 years, 10 months ago (2013-01-31 22:47:18 UTC) #1
jamesr
lgtm
7 years, 10 months ago (2013-02-01 00:20:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/12088095/1
7 years, 10 months ago (2013-02-01 17:03:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/12088095/1
7 years, 10 months ago (2013-02-01 17:38:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/12088095/1
7 years, 10 months ago (2013-02-02 03:41:04 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=106876
7 years, 10 months ago (2013-02-02 08:35:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/12088095/1
7 years, 10 months ago (2013-02-02 18:03:58 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=107113
7 years, 10 months ago (2013-02-02 20:46:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/12088095/1
7 years, 10 months ago (2013-02-04 05:07:39 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-04 05:09:16 UTC) #10
Message was sent while issue was closed. 
Change committed as 180350

Powered by Google App Engine
This is Rietveld 408576698