Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12088092: CrOS: Enable threaded UI compositor by default. (Closed)

Created:
7 years, 10 months ago by jonathan.backer
Modified:
7 years, 8 months ago
Reviewers:
Reid Kleckner, sky, bshe, piman
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, Ian Vollick, jonathan.backer, oshima+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

CrOS: Enable threaded UI compositor by default. BUG=173417 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193431

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Just for CrOS. #

Total comments: 2

Patch Set 4 : Keep for enable flag for other platforms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M ash/desktop_background/desktop_background_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/env.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M ui/compositor/compositor.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 1 chunk +11 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M ui/compositor/test/test_suite.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jonathan.backer
@bshe: Can you sign off on removing the DCHECK in ash/desktop_background/desktop_background_view.cc as per offline discussion? ...
7 years, 8 months ago (2013-04-09 12:56:59 UTC) #1
jonathan.backer
Gated on https://codereview.chromium.org/13866011/
7 years, 8 months ago (2013-04-09 14:59:24 UTC) #2
piman
https://codereview.chromium.org/12088092/diff/29010/ui/compositor/compositor.cc File ui/compositor/compositor.cc (right): https://codereview.chromium.org/12088092/diff/29010/ui/compositor/compositor.cc#newcode540 ui/compositor/compositor.cc:540: #if defined(OS_CHROMEOS) nit: can we keep the enable flag ...
7 years, 8 months ago (2013-04-09 17:46:24 UTC) #3
jonathan.backer
https://codereview.chromium.org/12088092/diff/29010/ui/compositor/compositor.cc File ui/compositor/compositor.cc (right): https://codereview.chromium.org/12088092/diff/29010/ui/compositor/compositor.cc#newcode540 ui/compositor/compositor.cc:540: #if defined(OS_CHROMEOS) On 2013/04/09 17:46:24, piman wrote: > nit: ...
7 years, 8 months ago (2013-04-09 19:37:15 UTC) #4
piman
LGTM - ty.
7 years, 8 months ago (2013-04-10 00:57:21 UTC) #5
bshe
On 2013/04/10 00:57:21, piman wrote: > LGTM - ty. Sorry for the delay. lgtm
7 years, 8 months ago (2013-04-10 15:57:53 UTC) #6
jonathan.backer
+sky for ash/desktop_background/desktop_background_view.cc and ui/aura/env.cc OWNERS
7 years, 8 months ago (2013-04-10 16:00:09 UTC) #7
sky
LGTM
7 years, 8 months ago (2013-04-10 16:28:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/12088092/31002
7 years, 8 months ago (2013-04-10 16:43:46 UTC) #9
commit-bot: I haz the power
Change committed as 193431
7 years, 8 months ago (2013-04-10 19:32:00 UTC) #10
Reid Kleckner
7 years, 8 months ago (2013-04-10 21:29:39 UTC) #11
Message was sent while issue was closed. 
This CL appears to have caused http://crbug.com/230082 .

Powered by Google App Engine
This is Rietveld 408576698