Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 12088089: Move DraggableRegion to top directory src/extensions/common (Closed)

Created:
7 years, 10 months ago by Joe Thomas
Modified:
7 years, 10 months ago
CC:
chromium-reviews, tfarina, jeremya+watch_chromium.org, dcheng, Aaron Boodman, sail+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@themes
Visibility:
Public.

Description

Move DraggableRegion to top directory src/extensions/common BUG=162530 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -45 lines) Patch
M chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/native_app_window_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/draggable_region.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/common/extensions/draggable_region.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 2 chunks +1 line, -1 line 0 comments Download
M extensions/common/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
A + extensions/common/draggable_region.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/draggable_region.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Joe Thomas
7 years, 10 months ago (2013-01-31 20:03:13 UTC) #1
Yoyo Zhou
LGTM
7 years, 10 months ago (2013-01-31 21:04:30 UTC) #2
Joe Thomas
TBR=ben@chromium.org for chrome/browser/ui/ & gyp
7 years, 10 months ago (2013-01-31 22:00:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12088089/1
7 years, 10 months ago (2013-01-31 22:10:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12088089/1
7 years, 10 months ago (2013-01-31 22:14:20 UTC) #5
commit-bot: I haz the power
Change committed as 180036
7 years, 10 months ago (2013-02-01 01:51:38 UTC) #6
Ben Goodger (Google)
7 years, 10 months ago (2013-02-04 18:40:25 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698