ECHO asset swap: add reference to 32-px icon.

ECHO asset swap: add reference to 32-px icon.

BUG=chromium-os:37884
TEST=manual verification

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180041

[hshi1, 2013-01-31 20:01:21]

Please take a look. In particular please advise when and in what manner can this
change be landed, because the "chrome32.png" logo requires the CrOS asset swap
to land first: https://gerrit-int.chromium.org/#/c/31860/

[Jorge Lucangeli Obes, 2013-01-31 20:35:31]

On 2013/01/31 20:30:14, hshi1 wrote:

So you need the CrOS CL to land *first*?

[hshi1, 2013-01-31 20:59:55]

On 2013/01/31 20:35:31, Jorge Lucangeli Obes wrote:
> On 2013/01/31 20:30:14, hshi1 wrote:
> 
> So you need the CrOS CL to land *first*?

Well not necessarily but the CrOS CL needs to land before the chromeos-chrome
ebuild points to a new chrome build that has the Chrome CL.

[Jorge Lucangeli Obes, 2013-01-31 21:18:45]

On 2013/01/31 20:59:55, hshi1 wrote:
> On 2013/01/31 20:35:31, Jorge Lucangeli Obes wrote:
> > On 2013/01/31 20:30:14, hshi1 wrote:
> > 
> > So you need the CrOS CL to land *first*?
> 
> Well not necessarily but the CrOS CL needs to land before the chromeos-chrome
> ebuild points to a new chrome build that has the Chrome CL.

So land the Chrome OS CL, make sure that sticks, and only then submit the Chrome
CL. It's not a fast process but it's the only way to guarantee it.

[Jorge Lucangeli Obes, 2013-01-31 21:19:26]

On 2013/01/31 21:18:45, Jorge Lucangeli Obes wrote:
> On 2013/01/31 20:59:55, hshi1 wrote:
> > On 2013/01/31 20:35:31, Jorge Lucangeli Obes wrote:
> > > On 2013/01/31 20:30:14, hshi1 wrote:
> > > 
> > > So you need the CrOS CL to land *first*?
> > 
> > Well not necessarily but the CrOS CL needs to land before the
chromeos-chrome
> > ebuild points to a new chrome build that has the Chrome CL.
> 
> So land the Chrome OS CL, make sure that sticks, and only then submit the
Chrome
> CL. It's not a fast process but it's the only way to guarantee it.

lgtm

[hshi1, 2013-01-31 21:20:08]

Thanks. While you're at it can you also LGTM the CrOS CL please
(https://gerrit-int.chromium.org/#/c/31860/)

[commit-bot: I haz the power, 2013-01-31 22:39:04]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[hshi1, 2013-01-31 22:43:10]

+xiyuan@ - can you please approve?

I initially thought jorgelo@'s LGTM is sufficient as he's on the OWNERS but
apparently CQ doesn't agree.

[xiyuan, 2013-01-31 22:46:09]

https://chromiumcodereview.appspot.com/12088088/diff/1/chrome/browser/resourc...
File chrome/browser/resources/chromeos/echo/manifest.json (right):

https://chromiumcodereview.appspot.com/12088088/diff/1/chrome/browser/resourc...
chrome/browser/resources/chromeos/echo/manifest.json:16: "16": "chrome16.png"
You are missing ',' here.

[hshi1, 2013-01-31 22:47:34]

https://chromiumcodereview.appspot.com/12088088/diff/1/chrome/browser/resourc...
File chrome/browser/resources/chromeos/echo/manifest.json (right):

https://chromiumcodereview.appspot.com/12088088/diff/1/chrome/browser/resourc...
chrome/browser/resources/chromeos/echo/manifest.json:16: "16": "chrome16.png"
On 2013/01/31 22:46:09, xiyuan wrote:
> You are missing ',' here.

Done.

[xiyuan, 2013-01-31 22:48:38]

lgtm

[commit-bot: I haz the power, 2013-01-31 23:00:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/12088088/6002