Issue 12088087: Android: Add content_browsertests_apk to the list of default targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12088087: Android: Add content_browsertests_apk to the list of default targets. (Closed)

Created:
7 years, 10 months ago by nilesh

Modified:
7 years, 10 months ago

Reviewers:
Yaron

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Add content_browsertests_apk to the list of default targets. BUG=138275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179965

Patch Set 2 : Removed from in progress target list. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/all_android.gyp	View	1	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm https://codereview.chromium.org/12088087/diff/1/build/all_android.gyp File build/all_android.gyp (right): https://codereview.chromium.org/12088087/diff/1/build/all_android.gyp#newcode128 build/all_android.gyp:128: '../content/content.gyp:content_browsertests', Remove from here?

7 years, 10 months ago (2013-01-31 17:43:07 UTC) #2

nilesh

https://codereview.chromium.org/12088087/diff/1/build/all_android.gyp File build/all_android.gyp (right): https://codereview.chromium.org/12088087/diff/1/build/all_android.gyp#newcode128 build/all_android.gyp:128: '../content/content.gyp:content_browsertests', On 2013/01/31 17:43:08, Yaron wrote: > Remove from ...

7 years, 10 months ago (2013-01-31 18:07:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12088087/5002

7 years, 10 months ago (2013-01-31 18:25:39 UTC) #4

Message was sent while issue was closed.

Change committed as 179965

Expand Messages | Collapse Messages

Issue 12088087: Android: Add content_browsertests_apk to the list of default targets. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Removed from in progress target list. #

Messages