Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: dbus/bus.cc

Issue 12088068: DBus: Bus::AddMatch and RemoveMatch support repeated rules. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: RemoveMatch returns a bool. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/bus.h ('k') | dbus/bus_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/bus.cc
diff --git a/dbus/bus.cc b/dbus/bus.cc
index 30b6cc31cfa8f15a888deba5fd993c1175dfc045..fd049e3db392e13effcc7e7c8904adbd537e0bcf 100644
--- a/dbus/bus.cc
+++ b/dbus/bus.cc
@@ -587,26 +587,38 @@ void Bus::AddMatch(const std::string& match_rule, DBusError* error) {
DCHECK(connection_);
AssertOnDBusThread();
- if (match_rules_added_.find(match_rule) != match_rules_added_.end()) {
+ std::map<std::string, int>::iterator iter =
+ match_rules_added_.find(match_rule);
+ if (iter != match_rules_added_.end()) {
+ // The already existing rule's counter is incremented.
+ iter->second++;
+
VLOG(1) << "Match rule already exists: " << match_rule;
return;
}
dbus_bus_add_match(connection_, match_rule.c_str(), error);
- match_rules_added_.insert(match_rule);
+ match_rules_added_[match_rule] = 1;
}
-void Bus::RemoveMatch(const std::string& match_rule, DBusError* error) {
+bool Bus::RemoveMatch(const std::string& match_rule, DBusError* error) {
DCHECK(connection_);
AssertOnDBusThread();
- if (match_rules_added_.find(match_rule) == match_rules_added_.end()) {
+ std::map<std::string, int>::iterator iter =
+ match_rules_added_.find(match_rule);
+ if (iter == match_rules_added_.end()) {
LOG(ERROR) << "Requested to remove an unknown match rule: " << match_rule;
- return;
+ return false;
}
- dbus_bus_remove_match(connection_, match_rule.c_str(), error);
- match_rules_added_.erase(match_rule);
+ // The rule's counter is decremented and the rule is deleted when reachs 0.
+ iter->second--;
+ if (iter->second == 0) {
+ dbus_bus_remove_match(connection_, match_rule.c_str(), error);
+ match_rules_added_.erase(match_rule);
+ }
+ return true;
}
bool Bus::TryRegisterObjectPath(const ObjectPath& object_path,
« no previous file with comments | « dbus/bus.h ('k') | dbus/bus_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698