Enable cloud policy by default.

Enable cloud policy by default.

BUG=141123
TBR=bauerb, willchan

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179578

[Andrew T Wilson (Slow), 2013-01-29 16:07:42]

PTAL

[Joao da Silva, 2013-01-29 17:02:28]

lgtm with a nit.

I generally dislike changing production code to fix tests; if possible, please
fix the tests instead :-) See inline.

https://codereview.chromium.org/12088022/diff/5002/chrome/browser/policy/brow...
File chrome/browser/policy/browser_policy_connector.cc (right):

https://codereview.chromium.org/12088022/diff/5002/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.cc:226: if
(device_management_service_.get())
Why not change the broken tests to call SetDeviceManagementServiceForTesting
with a MockDeviceManagementService?

https://codereview.chromium.org/12088022/diff/5002/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.cc:379: // users.
Why not change those tests to use real email addresses?

https://codereview.chromium.org/12088022/diff/5002/chrome/common/chrome_switc...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/12088022/diff/5002/chrome/common/chrome_switc...
chrome/common/chrome_switches.cc:797: // in to the browser.
Update the comment.

[Andrew T Wilson (Slow), 2013-01-29 17:26:46]

https://codereview.chromium.org/12088022/diff/5002/chrome/browser/policy/brow...
File chrome/browser/policy/browser_policy_connector.cc (right):

https://codereview.chromium.org/12088022/diff/5002/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.cc:226: if
(device_management_service_.get())
On 2013/01/29 17:02:28, Joao da Silva wrote:
> Why not change the broken tests to call SetDeviceManagementServiceForTesting
> with a MockDeviceManagementService?

Yeah, there are too many tests that break. I think the real fix is to pull the
call to ScheduleServiceInitialization out of UserPolicySigninService, so I'll
add a TODO here.

https://codereview.chromium.org/12088022/diff/5002/chrome/browser/policy/brow...
chrome/browser/policy/browser_policy_connector.cc:379: // users.
On 2013/01/29 17:02:28, Joao da Silva wrote:
> Why not change those tests to use real email addresses?
One could. Mainly I don't want to touch a boatload of tests, and I've
rationalized that I'm being true to the spirit of the routine because "test" is
not an enterprise user :-P

https://codereview.chromium.org/12088022/diff/5002/chrome/common/chrome_switc...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/12088022/diff/5002/chrome/common/chrome_switc...
chrome/common/chrome_switches.cc:797: // in to the browser.
On 2013/01/29 17:02:28, Joao da Silva wrote:
> Update the comment.

Done.

[Andrew T Wilson (Slow), 2013-01-29 17:28:49]

TBR-ing willchan/bauerb for renaming of pref/switches that touch browser/prefs
and browser/profile

[commit-bot: I haz the power, 2013-01-30 07:41:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/atwilson@chromium.org/12088022/5004

[commit-bot: I haz the power, 2013-01-30 09:59:43]

Change committed as 179578

[Bernhard Bauer, 2013-02-04 15:26:44]

Post-commit rubberstamp LGTM.