Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/ic.h

Issue 12088021: Only update POLYMORPHIC stubs using other POLYMORPHIC or GENERIC stubs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed nit Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 Handle<Code> code); 172 Handle<Code> code);
173 virtual void UpdateMegamorphicCache(Map* map, String* name, Code* code); 173 virtual void UpdateMegamorphicCache(Map* map, String* name, Code* code);
174 virtual Handle<Code> megamorphic_stub() { 174 virtual Handle<Code> megamorphic_stub() {
175 UNREACHABLE(); 175 UNREACHABLE();
176 return Handle<Code>::null(); 176 return Handle<Code>::null();
177 } 177 }
178 virtual Handle<Code> megamorphic_stub_strict() { 178 virtual Handle<Code> megamorphic_stub_strict() {
179 UNREACHABLE(); 179 UNREACHABLE();
180 return Handle<Code>::null(); 180 return Handle<Code>::null();
181 } 181 }
182 virtual Handle<Code> generic_stub() const {
183 UNREACHABLE();
184 return Handle<Code>::null();
185 }
186 virtual Handle<Code> generic_stub_strict() const {
187 UNREACHABLE();
188 return Handle<Code>::null();
189 }
182 190
183 private: 191 private:
184 // Frame pointer for the frame that uses (calls) the IC. 192 // Frame pointer for the frame that uses (calls) the IC.
185 Address fp_; 193 Address fp_;
186 194
187 // All access to the program counter of an IC structure is indirect 195 // All access to the program counter of an IC structure is indirect
188 // to make the code GC safe. This feature is crucial since 196 // to make the code GC safe. This feature is crucial since
189 // GetProperty and SetProperty are called and they in turn might 197 // GetProperty and SetProperty are called and they in turn might
190 // invoke the garbage collector. 198 // invoke the garbage collector.
191 Address* pc_address_; 199 Address* pc_address_;
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
802 810
803 // Helper for BinaryOpIC and CompareIC. 811 // Helper for BinaryOpIC and CompareIC.
804 enum InlinedSmiCheck { ENABLE_INLINED_SMI_CHECK, DISABLE_INLINED_SMI_CHECK }; 812 enum InlinedSmiCheck { ENABLE_INLINED_SMI_CHECK, DISABLE_INLINED_SMI_CHECK };
805 void PatchInlinedSmiCode(Address address, InlinedSmiCheck check); 813 void PatchInlinedSmiCode(Address address, InlinedSmiCheck check);
806 814
807 DECLARE_RUNTIME_FUNCTION(MaybeObject*, KeyedLoadIC_Miss); 815 DECLARE_RUNTIME_FUNCTION(MaybeObject*, KeyedLoadIC_Miss);
808 816
809 } } // namespace v8::internal 817 } } // namespace v8::internal
810 818
811 #endif // V8_IC_H_ 819 #endif // V8_IC_H_
OLDNEW
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698