Issue 12088021: Only update POLYMORPHIC stubs using other POLYMORPHIC or GENERIC stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12088021: Only update POLYMORPHIC stubs using other POLYMORPHIC or GENERIC stubs. (Closed)

Created:
7 years, 10 months ago by Toon Verwaest

Modified:
7 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Only update POLYMORPHIC stubs using other POLYMORPHIC or GENERIC stubs. Committed: https://code.google.com/p/v8/source/detail?r=13530

Patch Set 2 : Addressed nit #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	src/ic.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	src/ic.cc	View	1	4 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://chromiumcodereview.appspot.com/12088021/diff/1/src/ic.cc File src/ic.cc (right): https://chromiumcodereview.appspot.com/12088021/diff/1/src/ic.cc#newcode998 src/ic.cc:998: // While trying to patch a polymorphic stub ...

7 years, 10 months ago (2013-01-28 14:22:54 UTC) #2

Toon Verwaest

7 years, 10 months ago (2013-01-28 14:41:48 UTC) #3

Addressed comment. Landing.

https://chromiumcodereview.appspot.com/12088021/diff/1/src/ic.cc
File src/ic.cc (right):

https://chromiumcodereview.appspot.com/12088021/diff/1/src/ic.cc#newcode998
src/ic.cc:998: // While trying to patch a polymorphic stub with anything else
than
On 2013/01/28 14:22:55, Jakob wrote:
> nit: s/While/When/, s/else/other/

Done.

Expand Messages | Collapse Messages

Issue 12088021: Only update POLYMORPHIC stubs using other POLYMORPHIC or GENERIC stubs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed nit #

Messages