Changes to improve multiprocessing PRESUBMIT support in Windows

third_party/pylint/lint.py

 # Copyright (c) 2003-2014 LOGILAB S.A. (Paris, FRANCE).
 # http://www.logilab.fr/ -- mailto:contact@logilab.fr
 #
 # This program is free software; you can redistribute it and/or modify it under
 # the terms of the GNU General Public License as published by the Free Software
 # Foundation; either version 2 of the License, or (at your option) any later
 # version.
 #
 # This program is distributed in the hope that it will be useful, but WITHOUT
 # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
@@ skipping 653 matching lines @@
         # initialize msgs_state now that all messages have been registered into
         # the store
         for msg in self.msgs_store.messages:
             if not msg.may_be_emitted():
                 self._msgs_state[msg.msgid] = False
 
         if not isinstance(files_or_modules, (list, tuple)):
             files_or_modules = (files_or_modules,)
 
         if self.config.jobs == 1:
-            self._do_check(files_or_modules)
+            with fix_import_path(files_or_modules):

[iannucci, 2015/06/25 01:54:32]

note that all child checkers come through here

+                self._do_check(files_or_modules)
         else:
             # Hack that permits running pylint, on Windows, with -m switch
             # and with --jobs, as in 'python -2 -m pylint .. --jobs'.
             # For more details why this is needed,
             # see Python issue http://bugs.python.org/issue10845.
 
             mock_main = __name__ != '__main__' # -m switch
             if mock_main:
                 sys.modules['__main__'] = sys.modules[__name__]
             try:
@@ skipping 560 matching lines @@
             if multiprocessing is None:
                 print("Multiprocessing library is missing, "
                       "fallback to single process", file=sys.stderr)
                 linter.set_option("jobs", 1)
             else:
                 if linter.config.jobs == 0:
                     linter.config.jobs = multiprocessing.cpu_count()
 
         # insert current working directory to the python path to have a correct
         # behaviour
-        with fix_import_path(args):
-            if self.linter.config.profile:
+        if self.linter.config.profile:
+            with fix_import_path(args):
                 print('** profiled run', file=sys.stderr)
                 import cProfile, pstats
                 cProfile.runctx('linter.check(%r)' % args, globals(), locals(),
                                 'stones.prof')
                 data = pstats.Stats('stones.prof')
                 data.strip_dirs()
                 data.sort_stats('time', 'calls')
                 data.print_stats(30)
-            else:
-                linter.check(args)
-            linter.generate_reports()
+        else:
+            linter.check(args)
+        linter.generate_reports()

[iannucci, 2015/06/25 01:54:32]

report generation doesn't actually require the path hacks as far as I can tell.

         if exit:
             sys.exit(self.linter.msg_status)
 
     def cb_set_rcfile(self, name, value):
         """callback for option preprocessing (i.e. before option parsing)"""
         self._rcfile = value
 
     def cb_add_plugins(self, name, value):
         """callback for option preprocessing (i.e. before option parsing)"""
         self._plugins.extend(textutils.splitstrip(value))
@@ skipping 45 matching lines @@
         print('%-18s: %s' % level)
     sys.exit(0)
 
 def cb_init_hook(optname, value):
     """exec arbitrary code to set sys.path for instance"""
     exec(value) # pylint: disable=exec-used
 
 
 if __name__ == '__main__':
     Run(sys.argv[1:])