Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 12087131: Make the arm port build cleanly with Clang. (Closed)

Created:
7 years, 10 months ago by hans
Modified:
7 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Make the arm port build cleanly with Clang. This fixes the following two warnings, so that "make all" builds cleanly with Clang: src/arm/macro-assembler-arm.h:1410:7: error: private field 'instructions_' is not used [-Werror,-Wunused-private-field] int instructions_; // Number of instructions of the expected patch size. ^ src/arm/simulator-arm.cc:402:20: error: variable 'words' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] } else if (argc == next_arg + 1) { ^~~~~~~~~~~~~~~~~~~~ ../src/arm/simulator-arm.cc:407:21: note: uninitialized use occurs here end = cur + words; ^~~~~ ../src/arm/simulator-arm.cc:402:16: note: remove the 'if' if its condition is always true } else if (argc == next_arg + 1) { ^~~~~~~~~~~~~~~~~~~~~~~~~~ Committed: https://code.google.com/p/v8/source/detail?r=13583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hans
7 years, 10 months ago (2013-02-01 10:52:30 UTC) #1
ulan
LGTM, I will land it for you.
7 years, 10 months ago (2013-02-04 10:01:36 UTC) #2
ulan
7 years, 10 months ago (2013-02-04 10:31:02 UTC) #3
Message was sent while issue was closed.
Committed manually as r13583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698