Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 12087128: Enable win64 stub library generation (Closed)

Created:
7 years, 10 months ago by wolenetz
Modified:
7 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, jschuh, scottmg, fgalligan1
Visibility:
Public.

Description

Enable win64 stub library generation. Previously, /machine:X86 was the hardcoded lib option. This patch enables /machine:X64, if the file type parameter is 'windows_lib_x64'. To unblock media <-> ffmpeg win64 linking, this patch along with a separate patch to ffmpeg.gyp will be necessary. BUG=172938, 166496 TEST=win_rel try bot (win32). Private with additional fix to use 'windows_lib_x64' for win64 in ffmpeg.gyp eliminates media<->ffmpeg link errors in win64. Unittests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180184

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M tools/generate_stubs/generate_stubs.py View 10 chunks +25 lines, -13 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
wolenetz
Please review. Thanks! Matt
7 years, 10 months ago (2013-02-01 06:03:51 UTC) #1
DaleCurtis
https://codereview.chromium.org/12087128/diff/1/tools/generate_stubs/generate_stubs.py File tools/generate_stubs/generate_stubs.py (right): https://codereview.chromium.org/12087128/diff/1/tools/generate_stubs/generate_stubs.py#newcode888 tools/generate_stubs/generate_stubs.py:888: default=None, I think you'll need to keep the old ...
7 years, 10 months ago (2013-02-01 19:07:40 UTC) #2
wolenetz
https://codereview.chromium.org/12087128/diff/1/tools/generate_stubs/generate_stubs.py File tools/generate_stubs/generate_stubs.py (right): https://codereview.chromium.org/12087128/diff/1/tools/generate_stubs/generate_stubs.py#newcode888 tools/generate_stubs/generate_stubs.py:888: default=None, On 2013/02/01 19:07:40, DaleCurtis wrote: > I think ...
7 years, 10 months ago (2013-02-01 19:16:21 UTC) #3
DaleCurtis
Ah whoops, yeah I was thinking the Python constant name was the type name not ...
7 years, 10 months ago (2013-02-01 19:22:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12087128/1
7 years, 10 months ago (2013-02-01 19:45:04 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 20:55:22 UTC) #6
Message was sent while issue was closed.
Change committed as 180184

Powered by Google App Engine
This is Rietveld 408576698