Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 12087126: Fix shared memory leak on command buffer teardown (Closed)

Created:
7 years, 10 months ago by piman
Modified:
7 years, 10 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Fix shared memory leak on command buffer teardown When freeing mapped memory from the GLES2Implementation, it's pending token so we don't destroy the TranserBuffer. When we tear down the GLES2Implementation, there's still usually some TransferBuffers left, that never get explicitly destroyed in the command buffer. When the command buffer gets destroyed, it deletes the SharedMemory (which unmaps / closes), but doesn't tell the GPU process. In the GPU process, the TransferBuffers are managed per ContextGroup, not context, so they leak until the ContextGroup is destroyed. It can happen e.g. when closing pages that share a renderer with another one, or on Aura when creating/destroying root windows (on Chrome OS when unplugging a screen). BUG=chrome-os-partner:17496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/mapped_memory.cc View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
piman
7 years, 10 months ago (2013-02-01 04:17:24 UTC) #1
greggman
lgtm
7 years, 10 months ago (2013-02-01 06:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/12087126/1
7 years, 10 months ago (2013-02-01 07:49:17 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 10 months ago (2013-02-01 17:46:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/12087126/1
7 years, 10 months ago (2013-02-01 17:56:13 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 20:01:31 UTC) #6
Message was sent while issue was closed.
Change committed as 180177

Powered by Google App Engine
This is Rietveld 408576698