Issue 12087095: Sync csd.proto with server-side version.

Issue 12087095: Sync csd.proto with server-side version. (Closed)

Created:
7 years, 10 months ago by mattm

Modified:
7 years, 10 months ago

Reviewers:
benjhayden, noelutz, csilv, jam, Randy Smith (Not in Mondays), noé, not at google - send to devlin

CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, jam, kkania, Randy Smith (Not in Mondays), joi+watch-content_chromium.org, Aaron Boodman, arv (Not doing code reviews), robertshield, rdsmith+dwatch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, moheeb

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Sync csd.proto with server-side version. Adds DANGEROUS_HOST ClientDownloadResponse verdict and pipes it through the downloads system. For now we show the same warning message for both DANGEROUS_CONTENT and DANGEROUS_HOST. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180064

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : missing comma #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -10 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/download/chrome_download_manager_delegate.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/download/download_danger_prompt.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/download/download_item_model.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/downloads/downloads_api.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/downloads/downloads.js	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service_unittest.cc	View		2 chunks	+20 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/downloads_dom_handler.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/downloads.idl	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/common/safe_browsing/csd.proto	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/download/download_item_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/download/download_net_log_parameters.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/public/browser/download_danger_type.h	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	net/base/net_log_event_type_list.h	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

mattm

noelutz: for */safe_browsing/* benjhayden: for the rest moheeb: fyi

7 years, 10 months ago (2013-01-31 04:04:19 UTC) #1

benjhayden

Are there any plans to use a different warning message string? If not, why not ...

7 years, 10 months ago (2013-01-31 15:44:42 UTC) #2

benjhayden

https://codereview.chromium.org/12087095/diff/15001/chrome/browser/resources/downloads/downloads.js File chrome/browser/resources/downloads/downloads.js (right): https://codereview.chromium.org/12087095/diff/15001/chrome/browser/resources/downloads/downloads.js#newcode369 chrome/browser/resources/downloads/downloads.js:369: UNCOMMON_CONTENT: 'UNCOMMON_CONTENT' Need a comma at the end of ...

7 years, 10 months ago (2013-01-31 15:46:37 UTC) #3

mattm

On 2013/01/31 15:44:42, benjhayden_chromium wrote: > Are there any plans to use a different warning ...

7 years, 10 months ago (2013-01-31 21:45:57 UTC) #5

mattm

OWNERS reviews requested: rdsmith: content/public/browser jam: chrome/browser/automation kalman: chrome/browser/extensions, chrome/common/extensions csilv: chrome/browser/ui/webui, chrome/browser/resources

7 years, 10 months ago (2013-01-31 22:32:40 UTC) #7

Randy Smith (Not in Mondays)

content/public/browser/download_danger_type.h LGTM.

7 years, 10 months ago (2013-02-01 00:31:31 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/12087095/17002

7 years, 10 months ago (2013-02-01 00:46:15 UTC) #12

Message was sent while issue was closed.

Change committed as 180064

Expand Messages | Collapse Messages