Create unit-test for exiting context menus via mouse button

Create unit-test for exiting context menus via mouse button

Added a unit-test to BookmarkBarViewTest. It opens a context menu. The menu
is dismissed by clicking the mouse outside of it. The underlying view gets
the mouse event after the context menu has exited.

See also: https://chromiumcodereview.appspot.com/11761027

BUG=171891
TEST=manual
Run: 
out/Debug/interactive_ui_tests --gtest_filter='BookmarkBarViewTest20.*'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182037

[sky, 2013-01-30 14:53:04]

https://codereview.chromium.org/12087075/diff/1/chrome/browser/ui/views/bookm...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc (right):

https://codereview.chromium.org/12087075/diff/1/chrome/browser/ui/views/bookm...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:86: };
DISALLOW_...

https://codereview.chromium.org/12087075/diff/1/chrome/browser/ui/views/bookm...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:172: if
(!test_for_menu_exit_flag_) {
Why does this need to be here and not in your test? I much prefer moving to test
as then you don't need to modify constructor or change the base class in any
way.

https://codereview.chromium.org/12087075/diff/1/chrome/browser/ui/views/bookm...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:1629: #if
defined(USE_ASH) && defined(USE_X11)
Are you sure this is needed?

[sschmitz, 2013-01-30 20:43:57]

Thanks for your comments; it is much better. Made other improvements including
that the new width is computed rather than hard-coded.

https://codereview.chromium.org/12087075/diff/1/chrome/browser/ui/views/bookm...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc (right):

https://codereview.chromium.org/12087075/diff/1/chrome/browser/ui/views/bookm...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:86: };
On 2013/01/30 14:53:04, sky wrote:
> DISALLOW_...

Done.

https://codereview.chromium.org/12087075/diff/1/chrome/browser/ui/views/bookm...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:172: if
(!test_for_menu_exit_flag_) {
On 2013/01/30 14:53:04, sky wrote:
> Why does this need to be here and not in your test? I much prefer moving to
test
> as then you don't need to modify constructor or change the base class in any
> way.

Done.

https://codereview.chromium.org/12087075/diff/1/chrome/browser/ui/views/bookm...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:1629: #if
defined(USE_ASH) && defined(USE_X11)
On 2013/01/30 14:53:04, sky wrote:
> Are you sure this is needed?

I removed it. git try will tell us the answer;)
Done

[sky, 2013-01-30 23:01:57]

https://codereview.chromium.org/12087075/diff/4001/chrome/browser/ui/views/bo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc (right):

https://codereview.chromium.org/12087075/diff/4001/chrome/browser/ui/views/bo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:1608: int xx = 0;
Why are you adding directly to the bookmark bar view? Can't you add to the
parent and change or specify a different layout manager? That way you won't need
this code.

https://codereview.chromium.org/12087075/diff/4001/chrome/browser/ui/views/bo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:1611: if (right >
xx) xx = right;
no single ifs.

[sschmitz, 2013-01-31 01:31:45]

Thanks much for your help!

https://codereview.chromium.org/12087075/diff/4001/chrome/browser/ui/views/bo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc (right):

https://codereview.chromium.org/12087075/diff/4001/chrome/browser/ui/views/bo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:1608: int xx = 0;
On 2013/01/30 23:01:57, sky wrote:
> Why are you adding directly to the bookmark bar view? Can't you add to the
> parent and change or specify a different layout manager? That way you won't
need
> this code.

Done.

https://codereview.chromium.org/12087075/diff/4001/chrome/browser/ui/views/bo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:1611: if (right >
xx) xx = right;
On 2013/01/30 23:01:57, sky wrote:
> no single ifs.

Done.

[sky, 2013-01-31 02:01:59]

LGTM

[commit-bot: I haz the power, 2013-01-31 02:10:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087075/10001

[commit-bot: I haz the power, 2013-01-31 09:36:09]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-02-11 23:57:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087075/17001

[commit-bot: I haz the power, 2013-02-12 02:57:30]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-02-12 19:50:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087075/24003

[commit-bot: I haz the power, 2013-02-12 22:11:48]

Change committed as 182037