Improve JS unit tests.

Improve JS unit tests.

Currently, several JS files don't even have the basic "load" smoke-test
since they rely on globals not defined in the test environment. This CL
defines these globals so that they can be included in the basic test.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179576

[Jamie, 2013-01-29 22:56:19]

ptal

https://codereview.chromium.org/12087070/diff/1/remoting/webapp/all_js_load.g...
File remoting/webapp/all_js_load.gtestjs (right):

https://codereview.chromium.org/12087070/diff/1/remoting/webapp/all_js_load.g...
remoting/webapp/all_js_load.gtestjs:32: // file's days are numbered, skip it for
now.
I don't know if it's worth spending a lot of time trying to work out what's
going wrong here. WDYT?

[garykac, 2013-01-29 23:40:16]

lgtm

https://codereview.chromium.org/12087070/diff/1/remoting/webapp/all_js_load.g...
File remoting/webapp/all_js_load.gtestjs (right):

https://codereview.chromium.org/12087070/diff/1/remoting/webapp/all_js_load.g...
remoting/webapp/all_js_load.gtestjs:32: // file's days are numbered, skip it for
now.
On 2013/01/29 22:56:19, Jamie wrote:
> I don't know if it's worth spending a lot of time trying to work out what's
> going wrong here. WDYT?

SGTM. Doesn't seem worth it unless we're going to keep the file around for a
while.  Getting other JS tests working is more important.

[Jamie, 2013-01-29 23:51:22]

fyi

https://codereview.chromium.org/12087070/diff/1/remoting/webapp/all_js_load.g...
File remoting/webapp/all_js_load.gtestjs (right):

https://codereview.chromium.org/12087070/diff/1/remoting/webapp/all_js_load.g...
remoting/webapp/all_js_load.gtestjs:32: // file's days are numbered, skip it for
now.
On 2013/01/29 23:40:16, garykac wrote:
> On 2013/01/29 22:56:19, Jamie wrote:
> > I don't know if it's worth spending a lot of time trying to work out what's
> > going wrong here. WDYT?
> 
> SGTM. Doesn't seem worth it unless we're going to keep the file around for a
> while.  Getting other JS tests working is more important.

No, it's part of the OAuth flow, which will go away with apps v2. When we have
more comprehensive unit tests, we'll probably need to mock out some chrome.*
APIs, but that's a problem for another day.

[commit-bot: I haz the power, 2013-01-30 00:02:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/12087070/2002

[commit-bot: I haz the power, 2013-01-30 09:49:28]

Change committed as 179576