Chromium Code Reviews
Help | Chromium Project | Sign in
(23)

Issue 12087033: Status tray text looks too small compared to icons (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by sschmitz
Modified:
2 years ago
Reviewers:
jennyz
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Status tray text looks too small compared to icons. Changed the font size for the status tray text from 12 pixels to 13 pixels. Recently (Issue 166083), it had been changed from 14 pixels to 12 pixels in order to consolidate to standard font sizes, but that was subsequently deemed to small. sgabriel@ reviewed before and after screenshots of this change, which are attached to the bug report. BUG=169275 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179462

Patch Set 1 #

Total comments: 4

Patch Set 2 : crbug.com/169275 #

Messages

Total messages: 14 (0 generated)
sschmitz
2 years ago (2013-01-28 22:22:48 UTC) #1
jennyz
https://codereview.chromium.org/12087033/diff/1/ash/system/tray/tray_views.cc File ash/system/tray/tray_views.cc (right): https://codereview.chromium.org/12087033/diff/1/ash/system/tray/tray_views.cc#newcode702 ash/system/tray/tray_views.cc:702: // all but the first call. Don't need to ...
2 years ago (2013-01-29 00:04:49 UTC) #2
sschmitz
https://codereview.chromium.org/12087033/diff/1/ash/system/tray/tray_views.cc File ash/system/tray/tray_views.cc (right): https://codereview.chromium.org/12087033/diff/1/ash/system/tray/tray_views.cc#newcode702 ash/system/tray/tray_views.cc:702: // all but the first call. On 2013/01/29 00:04:49, ...
2 years ago (2013-01-29 00:34:55 UTC) #3
jennyz
lgtm
2 years ago (2013-01-29 01:06:37 UTC) #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
2 years ago (2013-01-29 01:15:22 UTC) #5
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
2 years ago (2013-01-29 01:57:33 UTC) #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
2 years ago (2013-01-29 02:16:05 UTC) #7
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
2 years ago (2013-01-29 02:31:16 UTC) #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
2 years ago (2013-01-29 04:51:46 UTC) #9
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
2 years ago (2013-01-29 05:09:53 UTC) #10
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
2 years ago (2013-01-29 17:07:49 UTC) #11
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
2 years ago (2013-01-29 17:29:09 UTC) #12
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
2 years ago (2013-01-29 22:16:24 UTC) #13
I haz the power (commit-bot)
2 years ago (2013-01-29 23:30:30 UTC) #14
Message was sent while issue was closed.
Change committed as 179462
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87e6a26