Chromium Code Reviews
Help | Chromium Project | Sign in
(640)

Issue 12087033: Status tray text looks too small compared to icons (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by sschmitz
Modified:
1 year, 2 months ago
Reviewers:
jennyz
CC:
chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Status tray text looks too small compared to icons.

Changed the font size for the status tray text from 12 pixels to 13 pixels. Recently (Issue 166083), it had been changed from 14 pixels to 12 pixels in order to consolidate to standard font sizes, but that was subsequently deemed to small. sgabriel@ reviewed before and after screenshots of this change, which are attached to the bug report.

BUG=169275
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179462

Patch Set 1 #

Total comments: 4

Patch Set 2 : crbug.com/169275 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Lint Patch
M ash/system/tray/tray_views.cc View 1 1 chunk +4 lines, -2 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 14
sschmitz
1 year, 2 months ago #1
jennyz
https://codereview.chromium.org/12087033/diff/1/ash/system/tray/tray_views.cc File ash/system/tray/tray_views.cc (right): https://codereview.chromium.org/12087033/diff/1/ash/system/tray/tray_views.cc#newcode702 ash/system/tray/tray_views.cc:702: // all but the first call. Don't need to ...
1 year, 2 months ago #2
sschmitz
https://codereview.chromium.org/12087033/diff/1/ash/system/tray/tray_views.cc File ash/system/tray/tray_views.cc (right): https://codereview.chromium.org/12087033/diff/1/ash/system/tray/tray_views.cc#newcode702 ash/system/tray/tray_views.cc:702: // all but the first call. On 2013/01/29 00:04:49, ...
1 year, 2 months ago #3
jennyz
lgtm
1 year, 2 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
1 year, 2 months ago #5
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
1 year, 2 months ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
1 year, 2 months ago #7
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
1 year, 2 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
1 year, 2 months ago #9
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
1 year, 2 months ago #10
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
1 year, 2 months ago #11
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
1 year, 2 months ago #12
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12087033/5001
1 year, 2 months ago #13
I haz the power (commit-bot)
1 year, 2 months ago #14
Message was sent while issue was closed.
Change committed as 179462
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434