Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12087006: aura: Do not include test code in production code. (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

aura: Do not include test code in production code. TEST=aura_unittests R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180045

Patch Set 1 #

Patch Set 2 : fix - rebase #

Patch Set 3 : ash_unittests fixed #

Patch Set 4 : fix win7_aura #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -30 lines) Patch
M ash/extended_desktop_unittest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ui/aura/test/window_test_api.h View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A ui/aura/test/window_test_api.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M ui/aura/window.h View 3 chunks +5 lines, -15 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
tfarina
7 years, 11 months ago (2013-01-25 23:13:29 UTC) #1
sky
LGTM
7 years, 11 months ago (2013-01-25 23:48:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12087006/1
7 years, 10 months ago (2013-01-29 02:00:18 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 02:31:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12087006/1
7 years, 10 months ago (2013-01-29 02:56:51 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 03:14:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12087006/6005
7 years, 10 months ago (2013-01-29 03:20:44 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 03:40:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12087006/11
7 years, 10 months ago (2013-01-31 20:39:38 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-31 22:38:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12087006/8004
7 years, 10 months ago (2013-01-31 23:17:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12087006/8004
7 years, 10 months ago (2013-02-01 00:44:25 UTC) #12
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 02:33:54 UTC) #13
Message was sent while issue was closed. 
Change committed as 180045

Powered by Google App Engine
This is Rietveld 408576698