Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 12086100: Fix conversion to from document/window points (Closed)

Created:
7 years, 10 months ago by cjhopman
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, aelias_OOO_until_Jul13
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix conversion to from document/window points The native scroll offsets are not scaled by the page scale factor. So, NormalizedPoint.updateWindowFromDocument and updateDocumentFromWindow need to be updated to properly calculate the conversion. BUG=169918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180063

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cjhopman
7 years, 10 months ago (2013-02-01 00:14:42 UTC) #1
cjhopman
tedchoc: *
7 years, 10 months ago (2013-02-01 00:14:52 UTC) #2
aelias_OOO_until_Jul13
lgtm with nit: https://codereview.chromium.org/12086100/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/12086100/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode221 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:221: */ Please clarify here: document = ...
7 years, 10 months ago (2013-02-01 00:18:32 UTC) #3
Ted C
lgtm
7 years, 10 months ago (2013-02-01 00:23:13 UTC) #4
cjhopman
https://codereview.chromium.org/12086100/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/12086100/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode221 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:221: */ On 2013/02/01 00:18:32, aelias wrote: > Please clarify ...
7 years, 10 months ago (2013-02-01 00:26:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12086100/4002
7 years, 10 months ago (2013-02-01 00:44:18 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 03:53:25 UTC) #7
Message was sent while issue was closed.
Change committed as 180063

Powered by Google App Engine
This is Rietveld 408576698