Issue 12086092: Implement audio constraints for PeerConneciton API

Issue 12086092: Implement audio constraints for PeerConneciton API (Closed)

Created:
7 years, 10 months ago by Alpha Left Google

Modified:
7 years, 10 months ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement audio constraints for PeerConneciton API Pass audio constraints to WebRTC. This is a reland after revert in r179832. Fixed memory leaks in unit tests in the last patch. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180044

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove one spa #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+168 lines, -35 lines)			Patch
M	content/renderer/media/media_stream_dependency_factory.h	View		2 chunks	+14 lines, -8 lines	0 comments	Download
M	content/renderer/media/media_stream_dependency_factory.cc	View		6 chunks	+26 lines, -12 lines	0 comments	Download
M	content/renderer/media/media_stream_dependency_factory_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/renderer/media/media_stream_impl_unittest.cc	View		6 chunks	+27 lines, -11 lines	0 comments	Download
M	content/renderer/media/media_stream_source_extra_data.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	content/renderer/media/mock_media_stream_dependency_factory.h	View		4 chunks	+39 lines, -2 lines	0 comments	Download
M	content/renderer/media/mock_media_stream_dependency_factory.cc	View	1	3 chunks	+47 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

lgtm with nit. https://codereview.chromium.org/12086092/diff/1/content/renderer/media/mock_media_stream_dependency_factory.cc File content/renderer/media/mock_media_stream_dependency_factory.cc (right): https://codereview.chromium.org/12086092/diff/1/content/renderer/media/mock_media_stream_dependency_factory.cc#newcode141 content/renderer/media/mock_media_stream_dependency_factory.cc:141: DCHECK(observer_ == observer); nit: remove one ...

7 years, 10 months ago (2013-01-31 21:32:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/12086092/16001

7 years, 10 months ago (2013-01-31 22:38:56 UTC) #2

Message was sent while issue was closed.

Change committed as 180044

Expand Messages | Collapse Messages