Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 12084080: [MIPS] Set defaults for mips/linux chrome builds. (Closed)

Created:
7 years, 10 months ago by petarj
Modified:
7 years, 10 months ago
Reviewers:
tony, brettw
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[MIPS] Set defaults for mips/linux chrome builds. Add default values for target_arch=="mipsel" in build/common.gypi. For sysroot, we will reuse native_client's mips-trusted sysroot. BUG= https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179820

Patch Set 1 #

Total comments: 4

Patch Set 2 : Delete the comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M build/common.gypi View 1 4 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
petarj
7 years, 10 months ago (2013-01-31 01:04:48 UTC) #1
tony
LGTM https://codereview.chromium.org/12084080/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12084080/diff/1/build/common.gypi#newcode620 build/common.gypi:620: }], # target_arch=="mipsel" Nit: I would remove the ...
7 years, 10 months ago (2013-01-31 01:13:09 UTC) #2
petarj
Second patch uploaded. https://codereview.chromium.org/12084080/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12084080/diff/1/build/common.gypi#newcode620 build/common.gypi:620: }], # target_arch=="mipsel" On 2013/01/31 01:13:09, ...
7 years, 10 months ago (2013-01-31 01:19:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/12084080/5001
7 years, 10 months ago (2013-01-31 01:38:41 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 07:56:48 UTC) #5
Message was sent while issue was closed.
Change committed as 179820

Powered by Google App Engine
This is Rietveld 408576698