Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6995)

Unified Diff: chrome/browser/search_engines/template_url_service_unittest.cc

Issue 12084076: Ensure post-sync TemplateURL of prepopulated engines use built-in version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change according to pkasting comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_unittest.cc b/chrome/browser/search_engines/template_url_service_unittest.cc
index a47ee9560a8492204b6a0839f5a41e89a422b6a8..5a6b2156dcdf4b8eda0857361ac88c76e4953eae 100644
--- a/chrome/browser/search_engines/template_url_service_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_unittest.cc
@@ -254,6 +254,7 @@ void TemplateURLServiceTest::AssertEquals(const TemplateURL& expected,
ASSERT_EQ(expected.url(), actual.url());
ASSERT_EQ(expected.suggestions_url(), actual.suggestions_url());
ASSERT_EQ(expected.favicon_url(), actual.favicon_url());
+ ASSERT_EQ(expected.alternate_urls(), actual.alternate_urls());
ASSERT_EQ(expected.show_in_default_list(), actual.show_in_default_list());
ASSERT_EQ(expected.safe_for_autoreplace(), actual.safe_for_autoreplace());
ASSERT_EQ(expected.input_encodings(), actual.input_encodings());
@@ -261,6 +262,8 @@ void TemplateURLServiceTest::AssertEquals(const TemplateURL& expected,
ASSERT_EQ(expected.date_created(), actual.date_created());
ASSERT_EQ(expected.last_modified(), actual.last_modified());
ASSERT_EQ(expected.sync_guid(), actual.sync_guid());
+ ASSERT_EQ(expected.search_terms_replacement_key(),
+ actual.search_terms_replacement_key());
}
void TemplateURLServiceTest::ExpectSimilar(const TemplateURL* expected,
@@ -272,9 +275,12 @@ void TemplateURLServiceTest::ExpectSimilar(const TemplateURL* expected,
EXPECT_EQ(expected->url(), actual->url());
EXPECT_EQ(expected->suggestions_url(), actual->suggestions_url());
EXPECT_EQ(expected->favicon_url(), actual->favicon_url());
+ EXPECT_EQ(expected->alternate_urls(), actual->alternate_urls());
EXPECT_EQ(expected->show_in_default_list(), actual->show_in_default_list());
EXPECT_EQ(expected->safe_for_autoreplace(), actual->safe_for_autoreplace());
EXPECT_EQ(expected->input_encodings(), actual->input_encodings());
+ EXPECT_EQ(expected->search_terms_replacement_key(),
+ actual->search_terms_replacement_key());
}
TemplateURL* TemplateURLServiceTest::CreatePreloadedTemplateURL(
@@ -1341,8 +1347,11 @@ TEST_F(TemplateURLServiceTest, TestManagedDefaultSearch) {
const char kSearchURL[] = "http://test.com/search?t={searchTerms}";
const char kIconURL[] = "http://test.com/icon.jpg";
const char kEncodings[] = "UTF-16;UTF-32";
+ const char kAlternateURL[] = "http://test.com/search#t={searchTerms}";
+ const char kSearchTermsReplacementKey[] = "espv";
test_util_.SetManagedDefaultSearchPreferences(true, kName, kKeyword,
- kSearchURL, std::string(), kIconURL, kEncodings);
+ kSearchURL, std::string(), kIconURL, kEncodings, kAlternateURL,
+ kSearchTermsReplacementKey);
VerifyObserverFired();
EXPECT_TRUE(model()->is_default_search_managed());
EXPECT_EQ(initial_count + 2, model()->GetTemplateURLs().size());
@@ -1355,6 +1364,8 @@ TEST_F(TemplateURLServiceTest, TestManagedDefaultSearch) {
data.favicon_url = GURL(kIconURL);
data.show_in_default_list = true;
base::SplitString(kEncodings, ';', &data.input_encodings);
+ data.alternate_urls.push_back(kAlternateURL);
+ data.search_terms_replacement_key = kSearchTermsReplacementKey;
Profile* profile = test_util_.profile();
scoped_ptr<TemplateURL> expected_managed_default1(new TemplateURL(profile,
data));
@@ -1369,7 +1380,8 @@ TEST_F(TemplateURLServiceTest, TestManagedDefaultSearch) {
const char kNewSearchURL[] = "http://other.com/search?t={searchTerms}";
const char kNewSuggestURL[] = "http://other.com/suggest?t={searchTerms}";
test_util_.SetManagedDefaultSearchPreferences(true, kNewName, kNewKeyword,
- kNewSearchURL, kNewSuggestURL, std::string(), std::string());
+ kNewSearchURL, kNewSuggestURL, std::string(), std::string(),
+ std::string(), std::string());
VerifyObserverFired();
EXPECT_TRUE(model()->is_default_search_managed());
EXPECT_EQ(initial_count + 2, model()->GetTemplateURLs().size());
@@ -1402,7 +1414,7 @@ TEST_F(TemplateURLServiceTest, TestManagedDefaultSearch) {
// Disable the default search provider through policy.
test_util_.SetManagedDefaultSearchPreferences(false, std::string(),
std::string(), std::string(), std::string(), std::string(),
- std::string());
+ std::string(), std::string(), std::string());
VerifyObserverFired();
EXPECT_TRUE(model()->is_default_search_managed());
EXPECT_TRUE(NULL == model()->GetDefaultSearchProvider());
@@ -1410,7 +1422,8 @@ TEST_F(TemplateURLServiceTest, TestManagedDefaultSearch) {
// Re-enable it.
test_util_.SetManagedDefaultSearchPreferences(true, kName, kKeyword,
- kSearchURL, std::string(), kIconURL, kEncodings);
+ kSearchURL, std::string(), kIconURL, kEncodings, kAlternateURL,
+ kSearchTermsReplacementKey);
VerifyObserverFired();
EXPECT_TRUE(model()->is_default_search_managed());
EXPECT_EQ(initial_count + 2, model()->GetTemplateURLs().size());
@@ -1437,7 +1450,7 @@ TEST_F(TemplateURLServiceTest, TestManagedDefaultSearch) {
test_util_.ResetModel(false);
test_util_.SetManagedDefaultSearchPreferences(false, std::string(),
std::string(), std::string(), std::string(), std::string(),
- std::string());
+ std::string(), std::string(), std::string());
test_util_.VerifyLoad();
EXPECT_TRUE(model()->is_default_search_managed());
EXPECT_TRUE(model()->GetDefaultSearchProvider() == NULL);
« no previous file with comments | « chrome/browser/search_engines/template_url_service_test_util.cc ('k') | chrome/browser/search_engines/util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698