Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4444)

Unified Diff: chrome/renderer/autofill/form_autofill_util.cc

Issue 12084024: Use WebInputElement.isCheckbox() and isRadioButton() API being exposed by https://bugs.webkit.org/s… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove the comment as issue is reported. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/autofill/heuristics/output/02_checkout_advanceautoparts.com.out » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/form_autofill_util.cc
diff --git a/chrome/renderer/autofill/form_autofill_util.cc b/chrome/renderer/autofill/form_autofill_util.cc
index 9b5cd05aac90560a9732959c0777e0d44bbf2e44..c04954160f8158845c0ee5992fff897e5dd7d9b8 100644
--- a/chrome/renderer/autofill/form_autofill_util.cc
+++ b/chrome/renderer/autofill/form_autofill_util.cc
@@ -574,21 +574,14 @@ bool IsSelectElement(const WebFormControlElement& element) {
}
bool IsCheckableElement(const WebInputElement* element) {
- // Is static for improving performance.
- CR_DEFINE_STATIC_LOCAL(WebString, kRadio, ("radio"));
- CR_DEFINE_STATIC_LOCAL(WebString, kCheckbox, ("checkbox"));
-
if (!element)
return false;
- WebString formControlType = element->formControlType();
- return formControlType == kCheckbox || formControlType == kRadio;
+ return element->isCheckbox() || element->isRadioButton();
}
bool IsAutofillableInputElement(const WebInputElement* element) {
- // TODO(ramankk): Uncomment IsCheckableElement part once we have solution
- // for the observed performance regression.
- return IsTextInput(element); // || IsCheckableElement(element);
+ return IsTextInput(element) || IsCheckableElement(element);
}
const string16 GetFormIdentifier(const WebFormElement& form) {
« no previous file with comments | « no previous file | chrome/test/data/autofill/heuristics/output/02_checkout_advanceautoparts.com.out » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698