Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 12082111: Delete AudioOutputMixer. (Closed)

Created:
7 years, 10 months ago by DaleCurtis
Modified:
7 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Delete AudioOutputMixer. Not used. If we do enable browser side mixing in the future it'll be based on AudioConverter. With renderer side mixing and AudioOutputProxy, there's not a pressing need for this function. BUG=none TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180072

Patch Set 1 #

Patch Set 2 : Fix .gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -730 lines) Patch
M media/audio/audio_manager_base.cc View 2 chunks +0 lines, -18 lines 0 comments Download
D media/audio/audio_output_mixer.h View 1 chunk +0 lines, -94 lines 0 comments Download
D media/audio/audio_output_mixer.cc View 1 chunk +0 lines, -248 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 12 chunks +0 lines, -195 lines 0 comments Download
M media/audio/audio_util.h View 1 chunk +0 lines, -9 lines 0 comments Download
M media/audio/audio_util.cc View 2 chunks +0 lines, -80 lines 0 comments Download
M media/audio/audio_util_unittest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M media/media.gyp View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
Part 1 of AudioManager cleanup!
7 years, 10 months ago (2013-02-01 00:27:42 UTC) #1
scherkus (not reviewing)
Deleting code! Woo! FYI media/media.gyp contains the following: 70 # TODO(dalecurtis): Temporarily disabled while switching ...
7 years, 10 months ago (2013-02-01 00:40:34 UTC) #2
DaleCurtis
Done!
7 years, 10 months ago (2013-02-01 01:02:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/12082111/4001
7 years, 10 months ago (2013-02-01 01:12:41 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 04:52:48 UTC) #5
Message was sent while issue was closed.
Change committed as 180072

Powered by Google App Engine
This is Rietveld 408576698