Issue 12082102: Add DeviceRegisterRequest.BROWSER and use it for chrome.

Issue 12082102: Add DeviceRegisterRequest.BROWSER and use it for chrome. (Closed)

Created:
7 years, 10 months ago by Andrew T Wilson (Slow)

Modified:
7 years, 10 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add DeviceRegisterRequest.BROWSER and use it for chrome. BUG=173108 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180316

Patch Set 2 : Review feedback. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
M	chrome/browser/policy/proto/device_management_backend.proto	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/policy/user_cloud_policy_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/testserver/device_management.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

LGTM with nits. https://codereview.chromium.org/12082102/diff/1/chrome/browser/policy/proto/device_management_backend.proto File chrome/browser/policy/proto/device_management_backend.proto (right): https://codereview.chromium.org/12082102/diff/1/chrome/browser/policy/proto/device_management_backend.proto#newcode24 chrome/browser/policy/proto/device_management_backend.proto:24: USER = 1; // Register for ...

7 years, 10 months ago (2013-01-31 16:07:02 UTC) #2

Andrew T Wilson (Slow)

Thx. https://codereview.chromium.org/12082102/diff/1/chrome/browser/policy/proto/device_management_backend.proto File chrome/browser/policy/proto/device_management_backend.proto (right): https://codereview.chromium.org/12082102/diff/1/chrome/browser/policy/proto/device_management_backend.proto#newcode24 chrome/browser/policy/proto/device_management_backend.proto:24: USER = 1; // Register for cros user ...

7 years, 10 months ago (2013-01-31 16:09:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/12082102/14001

7 years, 10 months ago (2013-02-03 17:31:05 UTC) #4

Message was sent while issue was closed.

Change committed as 180316

Expand Messages | Collapse Messages