Sets per-item timers rather than global timer.

Sets per-item timers rather than global timer.


BUG=163760, 169151
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180087

[dharcourt, 2013-01-30 23:24:46]

lgtm

https://codereview.chromium.org/12082081/diff/1/ui/message_center/message_pop...
File ui/message_center/message_popup_bubble.cc (right):

https://codereview.chromium.org/12082081/diff/1/ui/message_center/message_pop...
ui/message_center/message_popup_bubble.cc:84: }
I may be misapplying that to this, but it seems this may be one of those cases
where the Chromium style recommends not using inline constructors
(http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in...).

https://codereview.chromium.org/12082081/diff/1/ui/message_center/message_pop...
ui/message_center/message_popup_bubble.cc:205: autoclose_timers_.erase(iter);
Will this make autoclose_timers_ briefly contain a pointer to an invalid timer?
Is there any way this could be a problem? If so it seems like it would be easy
to remove the timer autoclose_timers_ before deleting it.

[Jun Mukai, 2013-01-31 18:59:09]

https://codereview.chromium.org/12082081/diff/1/ui/message_center/message_pop...
File ui/message_center/message_popup_bubble.cc (right):

https://codereview.chromium.org/12082081/diff/1/ui/message_center/message_pop...
ui/message_center/message_popup_bubble.cc:84: }
On 2013/01/30 23:24:47, dharcourt wrote:
> I may be misapplying that to this, but it seems this may be one of those cases
> where the Chromium style recommends not using inline constructors
>
(http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in...).

Thanks.  Moved out-of-line (and fixed PopupBubbleContentsView for consistency)

https://codereview.chromium.org/12082081/diff/1/ui/message_center/message_pop...
ui/message_center/message_popup_bubble.cc:205: autoclose_timers_.erase(iter);
On 2013/01/30 23:24:47, dharcourt wrote:
> Will this make autoclose_timers_ briefly contain a pointer to an invalid
timer?
> Is there any way this could be a problem? If so it seems like it would be easy
> to remove the timer autoclose_timers_ before deleting it.

using scoped_ptr to ensure releasing the object after erase()

[miket_OOO, 2013-01-31 22:55:15]

lgtm

[commit-bot: I haz the power, 2013-02-01 02:09:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/12082081/4001

[commit-bot: I haz the power, 2013-02-01 05:47:06]

Change committed as 180087