Issue 12082064: makes NotificationView aware of border.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12082064: makes NotificationView aware of border. (Closed)

Created:
7 years, 10 months ago by Jun Mukai

Modified:
7 years, 10 months ago

Reviewers:
miket_OOO, dharcourt

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

makes NotificationView aware of border. Separating the shadow border from the card isn't a good idea because the shadow doesn't follow the slide-out animation of its contents. Rather we should specify the shadow border directly to the card, and make the card aware of the border. BUG=172010 TEST=on device, open the message center and swipe the notification. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180047

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -39 lines)			Patch
	M	ui/message_center/message_center_bubble.cc	View		2 chunks	+3 lines, -35 lines	0 comments	Download
	M	ui/message_center/notification_view.cc	View		3 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dharcourt

LGTM. Beautifully simple way to achieve this. It's nice to have NotificationView support borders generally ...

7 years, 10 months ago (2013-01-30 02:22:15 UTC) #2

Jun Mukai

oh, found myself missing messages. miket, could you review this?

7 years, 10 months ago (2013-01-30 18:28:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12082064/1

7 years, 10 months ago (2013-01-31 23:17:01 UTC) #6

Message was sent while issue was closed.

Change committed as 180047

Expand Messages | Collapse Messages