Issue 12082023: Do not try to collect the map if the monomorphic IC stub has no map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12082023: Do not try to collect the map if the monomorphic IC stub has no map. (Closed)

Created:
7 years, 10 months ago by Toon Verwaest

Modified:
7 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Do not try to collect the map if the monomorphic IC stub has no map. This is necessary for monomorphic stubs that rely on instance types, such as ArrayLength, StringLength and FunctionPrototype. BUG=chromium:172345 Committed: https://code.google.com/p/v8/source/detail?r=13526

Patch Set 1 #

Patch Set 2 : Add regression test, stay monomorphic when no maps are found in original monomorphic stub. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -29 lines)			Patch
	M	src/ic.cc	View	1	3 chunks	+37 lines, -24 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-172345.js	View	1	1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

Added regression test and fixed the fix. PTAL now ;)

7 years, 10 months ago (2013-01-28 12:15:41 UTC) #2

lgtm

Expand Messages | Collapse Messages