Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2056)

Unified Diff: chrome/browser/web_resource/promo_resource_service.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_resource/promo_resource_service.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_resource/promo_resource_service.cc
diff --git a/chrome/browser/web_resource/promo_resource_service.cc b/chrome/browser/web_resource/promo_resource_service.cc
index 12ede8654f0beae8afc2bed49e3915533c430125..e9f7bb3f22d5c494f7d1b1d9f83e655d215ae052 100644
--- a/chrome/browser/web_resource/promo_resource_service.cc
+++ b/chrome/browser/web_resource/promo_resource_service.cc
@@ -11,7 +11,8 @@
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/prefs/pref_registry_simple.h"
-#include "chrome/browser/prefs/pref_service_syncable.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
+#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/web_resource/notification_promo.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_switches.h"
@@ -67,14 +68,16 @@ void PromoResourceService::RegisterPrefs(PrefRegistrySimple* registry) {
}
// static
-void PromoResourceService::RegisterUserPrefs(PrefServiceSyncable* prefs) {
+void PromoResourceService::RegisterUserPrefs(PrefService* prefs,
+ PrefRegistrySyncable* registry) {
// TODO(dbeam): remove in M28 when all prefs have been cleared.
// http://crbug.com/168887
- prefs->RegisterStringPref(prefs::kNtpPromoResourceCacheUpdate,
- "0",
- PrefServiceSyncable::UNSYNCABLE_PREF);
+ // TODO(joi): Remove PrefService parameter; move this to migration code.
+ registry->RegisterStringPref(prefs::kNtpPromoResourceCacheUpdate,
+ "0",
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
prefs->ClearPref(prefs::kNtpPromoResourceCacheUpdate);
- NotificationPromo::RegisterUserPrefs(prefs);
+ NotificationPromo::RegisterUserPrefs(prefs, registry);
}
PromoResourceService::PromoResourceService()
« no previous file with comments | « chrome/browser/web_resource/promo_resource_service.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698